| Message ID | 1375949650-9699-3-git-send-email-michal.kazior@tieto.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Michal Kazior <michal.kazior@tieto.com> writes: > This fixes checkpatch warning from the latest > 3.11-rc kernel tree. > > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > --- > drivers/net/wireless/ath/ath10k/pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c > index d95439b..1814af1 100644 > --- a/drivers/net/wireless/ath/ath10k/pci.c > +++ b/drivers/net/wireless/ath/ath10k/pci.c > @@ -803,8 +803,7 @@ static int ath10k_pci_start_ce(struct ath10k *ar) > continue; > > for (i = 0; i < completions; i++) { > - compl = kmalloc(sizeof(struct ath10k_pci_compl), > - GFP_KERNEL); > + compl = kmalloc(sizeof(*compl), GFP_KERNEL); > if (!compl) { > ath10k_warn("No memory for completion state\n"); > ath10k_pci_stop_ce(ar); Just out of curiosity, what's the warning? kmalloc() should be called with sizeof(*foo) style?
On 12 August 2013 16:26, Kalle Valo <kvalo@qca.qualcomm.com> wrote: > Michal Kazior <michal.kazior@tieto.com> writes: > >> This fixes checkpatch warning from the latest >> 3.11-rc kernel tree. >> >> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >> --- >> drivers/net/wireless/ath/ath10k/pci.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c >> index d95439b..1814af1 100644 >> --- a/drivers/net/wireless/ath/ath10k/pci.c >> +++ b/drivers/net/wireless/ath/ath10k/pci.c >> @@ -803,8 +803,7 @@ static int ath10k_pci_start_ce(struct ath10k *ar) >> continue; >> >> for (i = 0; i < completions; i++) { >> - compl = kmalloc(sizeof(struct ath10k_pci_compl), >> - GFP_KERNEL); >> + compl = kmalloc(sizeof(*compl), GFP_KERNEL); >> if (!compl) { >> ath10k_warn("No memory for completion state\n"); >> ath10k_pci_stop_ce(ar); > > Just out of curiosity, what's the warning? kmalloc() should be called > with sizeof(*foo) style? Checkpatch prints: CHECK: Prefer kmalloc(sizeof(*compl)...) over kmalloc(sizeof(struct ath10k_pci_compl)...) Pozdrawiam / Best regards, Micha? Kazior. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index d95439b..1814af1 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -803,8 +803,7 @@ static int ath10k_pci_start_ce(struct ath10k *ar) continue; for (i = 0; i < completions; i++) { - compl = kmalloc(sizeof(struct ath10k_pci_compl), - GFP_KERNEL); + compl = kmalloc(sizeof(*compl), GFP_KERNEL); if (!compl) { ath10k_warn("No memory for completion state\n"); ath10k_pci_stop_ce(ar);
This fixes checkpatch warning from the latest 3.11-rc kernel tree. Signed-off-by: Michal Kazior <michal.kazior@tieto.com> --- drivers/net/wireless/ath/ath10k/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)