diff mbox

ath10k: fix tracing of ath10k_wmi_cmd

Message ID 1379576649-3947-1-git-send-email-michal.kazior@tieto.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Michal Kazior Sept. 19, 2013, 7:44 a.m. UTC
One of my recent patches broke tracing. kbuild
test robot reported this issue.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
 drivers/net/wireless/ath/ath10k/trace.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Sept. 20, 2013, 5:01 a.m. UTC | #1
Michal Kazior <michal.kazior@tieto.com> writes:

> One of my recent patches broke tracing. kbuild
> test robot reported this issue.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

Bad luck as I had accidentally tracing disabled on my test build. Patch
applied, but changed the commit log to:

commit 9e84f653ac16b718dd2305abe64a29bb3428621e
Author: Michal Kazior <michal.kazior@tieto.com>
Date:   Thu Sep 19 09:44:09 2013 +0200

    ath10k: fix tracing build for ath10k_wmi_cmd
    
    Commit be8b394390 ("ath10k: make WMI commands block by design") broke
    the build if CONFIG_ATH10K_TRACING was enabled.
    
    Reported-by: kbuild test robot <fengguang.wu@intel.com>
    Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/trace.h b/drivers/net/wireless/ath/ath10k/trace.h
index fd53130..90817dd 100644
--- a/drivers/net/wireless/ath/ath10k/trace.h
+++ b/drivers/net/wireless/ath/ath10k/trace.h
@@ -119,7 +119,7 @@  TRACE_EVENT(ath10k_wmi_cmd,
 		__field(unsigned int, id)
 		__field(size_t, buf_len)
 		__dynamic_array(u8, buf, buf_len)
-		__field(int ret)
+		__field(int, ret)
 	),
 
 	TP_fast_assign(