diff mbox

brcmsmac: remove dependency on CRC8 and CRC_CCITT

Message ID 1385327021-26851-1-git-send-email-hauke@hauke-m.de (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Hauke Mehrtens Nov. 24, 2013, 9:03 p.m. UTC
There is no code in brcmsmac that uses a function from CRC8 or
CRC_CCITT any more. Building brcmsmac with these two disabled works
without any problems. This was probably only used by the bus code which
was replaced by bcma some time ago.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/net/wireless/brcm80211/Kconfig |    2 --
 1 file changed, 2 deletions(-)

Comments

Arend van Spriel Nov. 25, 2013, 9:25 a.m. UTC | #1
On 11/24/2013 10:03 PM, Hauke Mehrtens wrote:
> There is no code in brcmsmac that uses a function from CRC8 or
> CRC_CCITT any more. Building brcmsmac with these two disabled works
> without any problems. This was probably only used by the bus code which
> was replaced by bcma some time ago.

True. These could be removed when using bcma. Thanks for cleaning that up.

Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>   drivers/net/wireless/brcm80211/Kconfig |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig
> index b00a7e9..ce0add3 100644
> --- a/drivers/net/wireless/brcm80211/Kconfig
> +++ b/drivers/net/wireless/brcm80211/Kconfig
> @@ -7,8 +7,6 @@ config BRCMSMAC
>   	depends on BCMA
>   	select BRCMUTIL
>   	select FW_LOADER
> -	select CRC_CCITT
> -	select CRC8
>   	select CORDIC
>   	---help---
>   	  This module adds support for PCIe wireless adapters based on Broadcom
>


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig
index b00a7e9..ce0add3 100644
--- a/drivers/net/wireless/brcm80211/Kconfig
+++ b/drivers/net/wireless/brcm80211/Kconfig
@@ -7,8 +7,6 @@  config BRCMSMAC
 	depends on BCMA
 	select BRCMUTIL
 	select FW_LOADER
-	select CRC_CCITT
-	select CRC8
 	select CORDIC
 	---help---
 	  This module adds support for PCIe wireless adapters based on Broadcom