| Message ID | 1385474260-22385-2-git-send-email-michal.kazior@tieto.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 26 November 2013 14:57, Michal Kazior <michal.kazior@tieto.com> wrote: > Calculating STA NSS just from the mcs rateset is > not the greatest idea. > > This should prevent connectivity issues if > mac80211 is ever to set rx_nss to something other > rather than base on max mcs map. As an example > operation mode change notification in assoc > request may change rx_nss initial values in the > future. > > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > --- Drop this single patch, please. I just noticed rx_nss doesn't seem to have correct value when associating.. Micha? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Michal Kazior <michal.kazior@tieto.com> writes: > On 26 November 2013 14:57, Michal Kazior <michal.kazior@tieto.com> wrote: >> Calculating STA NSS just from the mcs rateset is >> not the greatest idea. >> >> This should prevent connectivity issues if >> mac80211 is ever to set rx_nss to something other >> rather than base on max mcs map. As an example >> operation mode change notification in assoc >> request may change rx_nss initial values in the >> future. >> >> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >> --- > > Drop this single patch, please. > > I just noticed rx_nss doesn't seem to have correct value when associating.. Ok, I'm dropping this.
On Wed, 2013-11-27 at 11:25 +0100, Michal Kazior wrote: > On 26 November 2013 14:57, Michal Kazior <michal.kazior@tieto.com> wrote: > > Calculating STA NSS just from the mcs rateset is > > not the greatest idea. > > > > This should prevent connectivity issues if > > mac80211 is ever to set rx_nss to something other > > rather than base on max mcs map. As an example > > operation mode change notification in assoc > > request may change rx_nss initial values in the > > future. > > > > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > > --- > > Drop this single patch, please. > > I just noticed rx_nss doesn't seem to have correct value when associating.. FWIW, there are pending changes to make the opmode data come from hostapd to mac80211 so that this would be set correctly when the station is associating. Or where did you find it wasn't set correctly? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index b70a3b2..15eda44 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -925,7 +925,7 @@ static void ath10k_peer_assoc_h_basic(struct ath10k *ar, else arg->peer_listen_intval = ar->hw->conf.listen_interval; - arg->peer_num_spatial_streams = 1; + arg->peer_num_spatial_streams = max_t(u32, 1, sta->rx_nss); /* * The assoc capabilities are available only in managed mode. @@ -1075,7 +1075,6 @@ static void ath10k_peer_assoc_h_ht(struct ath10k *ar, arg->peer_ht_rates.rates[n++] = i; arg->peer_ht_rates.num_rates = n; - arg->peer_num_spatial_streams = max((n+7) / 8, 1); ath10k_dbg(ATH10K_DBG_MAC, "mac ht peer %pM mcs cnt %d nss %d\n", arg->addr,
Calculating STA NSS just from the mcs rateset is not the greatest idea. This should prevent connectivity issues if mac80211 is ever to set rx_nss to something other rather than base on max mcs map. As an example operation mode change notification in assoc request may change rx_nss initial values in the future. Signed-off-by: Michal Kazior <michal.kazior@tieto.com> --- drivers/net/wireless/ath/ath10k/mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)