| Message ID | 1385981647-4147-1-git-send-email-michal.kazior@tieto.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Mon, 2013-12-02 at 11:54 +0100, Michal Kazior wrote: > Drivers with hardware rate control were given > sta->rx_nss set to 0. This was because rx_nss > calculation procedure was protected by hw/sw rate > control check. > > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > --- > Hi Johannes, > > I've re-checked the issue I've mentioned with the patch 'ath10k: use nss > provided by mac80211'. > > Apparently drivers with HW rate control are only affected by this bug > and this patch is what I came up with as a quick fix. Any comments? Yeah this looks reasonable. I guess I'll apply it despite the [RFC] johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2013-12-02 at 11:54 +0100, Michal Kazior wrote: > Drivers with hardware rate control were given > sta->rx_nss set to 0. This was because rx_nss > calculation procedure was protected by hw/sw rate > control check. Applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/mac80211/rate.h b/net/mac80211/rate.h index 5dedc56..32cdbd2 100644 --- a/net/mac80211/rate.h +++ b/net/mac80211/rate.h @@ -54,6 +54,8 @@ static inline void rate_control_rate_init(struct sta_info *sta) struct ieee80211_supported_band *sband; struct ieee80211_chanctx_conf *chanctx_conf; + ieee80211_sta_set_rx_nss(sta); + if (!ref) return; @@ -67,8 +69,6 @@ static inline void rate_control_rate_init(struct sta_info *sta) sband = local->hw.wiphy->bands[chanctx_conf->def.chan->band]; - ieee80211_sta_set_rx_nss(sta); - ref->ops->rate_init(ref->priv, sband, &chanctx_conf->def, ista, priv_sta); rcu_read_unlock();
Drivers with hardware rate control were given sta->rx_nss set to 0. This was because rx_nss calculation procedure was protected by hw/sw rate control check. Signed-off-by: Michal Kazior <michal.kazior@tieto.com> --- Hi Johannes, I've re-checked the issue I've mentioned with the patch 'ath10k: use nss provided by mac80211'. Apparently drivers with HW rate control are only affected by this bug and this patch is what I came up with as a quick fix. Any comments? net/mac80211/rate.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)