| Message ID | 1387040625-38114-6-git-send-email-nbd@openwrt.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Felix Fietkau wrote: > - if (ah->config.pcie_clock_req) > - INIT_INI_ARRAY(&ah->iniPcieSerdes, > - ar9280PciePhy_clkreq_off_L1_9280); > - else > - INIT_INI_ARRAY(&ah->iniPcieSerdes, > - ar9280PciePhy_clkreq_always_on_L1_9280); > + INIT_INI_ARRAY(&ah->iniPcieSerdes, > + ar9280PciePhy_clkreq_always_on_L1_9280); > > if (AR_SREV_9287_11_OR_LATER(ah)) { > INIT_INI_ARRAY(&ah->iniModes, ar9287Modes_9287_1_1); > diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c > index a403cfc..eeb0741 100644 > --- a/drivers/net/wireless/ath/ath9k/hw.c > +++ b/drivers/net/wireless/ath/ath9k/hw.c > @@ -446,7 +446,6 @@ static void ath9k_hw_init_config(struct ath_hw *ah) > ah->config.additional_swba_backoff = 0; > ah->config.ack_6mb = 0x0; > ah->config.cwm_ignore_extcca = 0; > - ah->config.pcie_clock_req = 0; > ah->config.analog_shiftreg = 1; Please leave this in the driver, this has to be set for selected cards. I'll look at the Windows registry and add platform support. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-12-16 04:44, Sujith Manoharan wrote: > Felix Fietkau wrote: >> - if (ah->config.pcie_clock_req) >> - INIT_INI_ARRAY(&ah->iniPcieSerdes, >> - ar9280PciePhy_clkreq_off_L1_9280); >> - else >> - INIT_INI_ARRAY(&ah->iniPcieSerdes, >> - ar9280PciePhy_clkreq_always_on_L1_9280); >> + INIT_INI_ARRAY(&ah->iniPcieSerdes, >> + ar9280PciePhy_clkreq_always_on_L1_9280); >> >> if (AR_SREV_9287_11_OR_LATER(ah)) { >> INIT_INI_ARRAY(&ah->iniModes, ar9287Modes_9287_1_1); >> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c >> index a403cfc..eeb0741 100644 >> --- a/drivers/net/wireless/ath/ath9k/hw.c >> +++ b/drivers/net/wireless/ath/ath9k/hw.c >> @@ -446,7 +446,6 @@ static void ath9k_hw_init_config(struct ath_hw *ah) >> ah->config.additional_swba_backoff = 0; >> ah->config.ack_6mb = 0x0; >> ah->config.cwm_ignore_extcca = 0; >> - ah->config.pcie_clock_req = 0; >> ah->config.analog_shiftreg = 1; > > Please leave this in the driver, this has to be set for selected > cards. I'll look at the Windows registry and add platform support. Fine with me, let's leave this one out and merge the others (if there aren't any other issues). - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Felix Fietkau wrote: > Fine with me, let's leave this one out and merge the others (if there > aren't any other issues). Station mode seems fine with the series, I didn't get a chance to test IBSS or P2P. In AP mode, the timestamp in the first beacon is higher than earlier, since we no longer reset the HW TSF when enabling beaconing and there is a window between start() and enable_beacon(). I am not sure if this is a problem, but I think the spec has something to say about BSS creation in infrastructure mode. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-12-16 14:09, Sujith Manoharan wrote: > Felix Fietkau wrote: >> Fine with me, let's leave this one out and merge the others (if there >> aren't any other issues). > > Station mode seems fine with the series, I didn't get a chance to test > IBSS or P2P. > > In AP mode, the timestamp in the first beacon is higher than earlier, since > we no longer reset the HW TSF when enabling beaconing and there is a > window between start() and enable_beacon(). I am not sure if this is a > problem, but I think the spec has something to say about BSS creation in > infrastructure mode. I looked through the spec and could not find any indication that starting at zero is mandatory. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2013-12-16 at 14:51 +0100, Felix Fietkau wrote: > On 2013-12-16 14:09, Sujith Manoharan wrote: > > Felix Fietkau wrote: > >> Fine with me, let's leave this one out and merge the others (if there > >> aren't any other issues). > > > > Station mode seems fine with the series, I didn't get a chance to test > > IBSS or P2P. > > > > In AP mode, the timestamp in the first beacon is higher than earlier, since > > we no longer reset the HW TSF when enabling beaconing and there is a > > window between start() and enable_beacon(). I am not sure if this is a > > problem, but I think the spec has something to say about BSS creation in > > infrastructure mode. > I looked through the spec and could not find any indication that > starting at zero is mandatory. I don't believe you have to start at 0 - but it requires that TSF=0 is a DTIM TBTT. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_hw.c b/drivers/net/wireless/ath/ath9k/ar9002_hw.c index 5c95fd9..149aba3 100644 --- a/drivers/net/wireless/ath/ath9k/ar9002_hw.c +++ b/drivers/net/wireless/ath/ath9k/ar9002_hw.c @@ -32,12 +32,8 @@ static int ar9002_hw_init_mode_regs(struct ath_hw *ah) return 0; } - if (ah->config.pcie_clock_req) - INIT_INI_ARRAY(&ah->iniPcieSerdes, - ar9280PciePhy_clkreq_off_L1_9280); - else - INIT_INI_ARRAY(&ah->iniPcieSerdes, - ar9280PciePhy_clkreq_always_on_L1_9280); + INIT_INI_ARRAY(&ah->iniPcieSerdes, + ar9280PciePhy_clkreq_always_on_L1_9280); if (AR_SREV_9287_11_OR_LATER(ah)) { INIT_INI_ARRAY(&ah->iniModes, ar9287Modes_9287_1_1); diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index a403cfc..eeb0741 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c +++ b/drivers/net/wireless/ath/ath9k/hw.c @@ -446,7 +446,6 @@ static void ath9k_hw_init_config(struct ath_hw *ah) ah->config.additional_swba_backoff = 0; ah->config.ack_6mb = 0x0; ah->config.cwm_ignore_extcca = 0; - ah->config.pcie_clock_req = 0; ah->config.analog_shiftreg = 1; for (i = 0; i < AR_EEPROM_MODAL_SPURS; i++) { diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h index 3a70682..b8e2476 100644 --- a/drivers/net/wireless/ath/ath9k/hw.h +++ b/drivers/net/wireless/ath/ath9k/hw.h @@ -283,7 +283,6 @@ struct ath9k_ops_config { int additional_swba_backoff; int ack_6mb; u32 cwm_ignore_extcca; - u8 pcie_clock_req; u32 pcie_waen; u8 analog_shiftreg; u32 ofdm_trig_low;
It is unused Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath9k/ar9002_hw.c | 8 ++------ drivers/net/wireless/ath/ath9k/hw.c | 1 - drivers/net/wireless/ath/ath9k/hw.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-)