diff mbox

[4/4,v2] ath10k: invalid msdu-id logging

Message ID 1395688844-24640-5-git-send-email-greearb@candelatech.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Ben Greear March 24, 2014, 7:20 p.m. UTC 
From: Ben Greear <greearb@candelatech.com>

Make this message more obvious that it is a serious
problem (will cause tx flush issues, at least).

Signed-off-by: Ben Greear <greearb@candelatech.com>
---

v2:  Add this to series, but ordering is not overly important.

 drivers/net/wireless/ath/ath10k/txrx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo March 25, 2014, 12:02 p.m. UTC | #1 
greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Make this message more obvious that it is a serious
> problem (will cause tx flush issues, at least).
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2:  Add this to series, but ordering is not overly important.
>

[...]

> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>  		   tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>  
>  	if (tx_done->msdu_id >= htt->max_num_pending_tx) {
> -		ath10k_warn("warning: msdu_id %d too big, ignoring\n",
> +		ath10k_warn("error: msdu_id %d too big, ignoring\n",
>  			    tx_done->msdu_id);
>  		return;
>  	}

To me any warning is a serious matter, I'm not sure how changing this to
message to use "error:" makes any difference?
Ben Greear March 25, 2014, 3:56 p.m. UTC | #2 
On 03/25/2014 05:02 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
> 
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Make this message more obvious that it is a serious
>> problem (will cause tx flush issues, at least).
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>>
>> v2:  Add this to series, but ordering is not overly important.
>>
> 
> [...]
> 
>> --- a/drivers/net/wireless/ath/ath10k/txrx.c
>> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
>> @@ -58,7 +58,7 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
>>  		   tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
>>  
>>  	if (tx_done->msdu_id >= htt->max_num_pending_tx) {
>> -		ath10k_warn("warning: msdu_id %d too big, ignoring\n",
>> +		ath10k_warn("error: msdu_id %d too big, ignoring\n",
>>  			    tx_done->msdu_id);
>>  		return;
>>  	}
> 
> To me any warning is a serious matter, I'm not sure how changing this to
> message to use "error:" makes any difference?

To me, warning is bad, but probably not critical.  Error would be a failure that
is not (easily) recovered from.  In the case above, the result of this problem
would be effectively a reference counting leak that hangs the driver for 5 seconds
(under rtnl lock, I believe) each time the driver tries to flush.  This will never
recover until firmware is restarted.

So, I think it is more of an error than warning, but it is not a big deal
either way, so feel free to just drop the patch.

Thanks,
Ben
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c
index 0541dd9..9be5974 100644
--- a/drivers/net/wireless/ath/ath10k/txrx.c
+++ b/drivers/net/wireless/ath/ath10k/txrx.c
@@ -58,7 +58,7 @@  void ath10k_txrx_tx_unref(struct ath10k_htt *htt,
 		   tx_done->msdu_id, !!tx_done->discard, !!tx_done->no_ack);
 
 	if (tx_done->msdu_id >= htt->max_num_pending_tx) {
-		ath10k_warn("warning: msdu_id %d too big, ignoring\n",
+		ath10k_warn("error: msdu_id %d too big, ignoring\n",
 			    tx_done->msdu_id);
 		return;
 	}