| Message ID | 1400068627-4076-1-git-send-email-bartosz.markowski@tieto.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Bartosz Markowski <bartosz.markowski@tieto.com> writes: > On ARM-based (MSM mach), the pci_assign_resource() is passing > some invalid pointers and leading to L2 cache errors, > what prevents the PCI communication completly. > > So far I have not found this funtion to be directly called by > any other wifi driver and did not found this assigning needed > on any other platform. So removing it completly. Typo, it should be "completely". I have fixed this up in ath-next-test.
Bartosz Markowski <bartosz.markowski@tieto.com> writes: > On ARM-based (MSM mach), the pci_assign_resource() is passing > some invalid pointers and leading to L2 cache errors, > what prevents the PCI communication completly. > > So far I have not found this funtion to be directly called by > any other wifi driver and did not found this assigning needed > on any other platform. So removing it completly. > > Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> Thanks, applied.
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 66b1f30..9a579cd 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2602,18 +2602,6 @@ static int ath10k_pci_probe(struct pci_dev *pdev, pci_set_drvdata(pdev, ar); - /* - * Without any knowledge of the Host, the Target may have been reset or - * power cycled and its Config Space may no longer reflect the PCI - * address space that was assigned earlier by the PCI infrastructure. - * Refresh it now. - */ - ret = pci_assign_resource(pdev, BAR_NUM); - if (ret) { - ath10k_err("failed to assign PCI space: %d\n", ret); - goto err_ar; - } - ret = pci_enable_device(pdev); if (ret) { ath10k_err("failed to enable PCI device: %d\n", ret);
On ARM-based (MSM mach), the pci_assign_resource() is passing some invalid pointers and leading to L2 cache errors, what prevents the PCI communication completly. So far I have not found this funtion to be directly called by any other wifi driver and did not found this assigning needed on any other platform. So removing it completly. Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> --- drivers/net/wireless/ath/ath10k/pci.c | 12 ------------ 1 file changed, 12 deletions(-)