@@ -281,11 +281,13 @@ struct ath10k_vif_iter {
* @ATH10K_FW_ERROR_DUMP_DBGLOG: Recent firmware debug log entries
* @ATH10K_FW_ERROR_DUMP_REGDUMP: Register crash dump in binary format
* @ATH10K_FW_ERROR_DUMP_STACK: Stack memory contents.
+ * @ATH10K_FW_ERROR_DUMP_EXC_STACK: Exception stack contents
*/
enum ath10k_fw_error_dump_type {
ATH10K_FW_ERROR_DUMP_DBGLOG = 0,
ATH10K_FW_ERROR_DUMP_REGDUMP = 1,
ATH10K_FW_ERROR_DUMP_STACK = 2,
+ ATH10K_FW_ERROR_DUMP_EXC_STACK = 3,
ATH10K_FW_ERROR_DUMP_MAX,
};
@@ -367,6 +369,7 @@ struct ath10k_debug {
struct ath10k_dbglog_entry_storage dbglog_entry_data;
u32 reg_dump_values[REG_DUMP_COUNT_QCA988X];
unsigned char stack_buf[ATH10K_FW_STACK_SIZE];
+ unsigned char exc_stack_buf[ATH10K_FW_STACK_SIZE];
};
enum ath10k_state {
@@ -623,6 +623,7 @@ static struct ath10k_dump_file_data *ath10k_build_dump_file(struct ath10k *ar)
len += sizeof(*dump_tlv) + sizeof(ar->debug.reg_dump_values);
len += sizeof(*dump_tlv) + sizeof(ar->debug.dbglog_entry_data);
len += sizeof(*dump_tlv) + sizeof(ar->debug.stack_buf);
+ len += sizeof(*dump_tlv) + sizeof(ar->debug.exc_stack_buf);
lockdep_assert_held(&ar->conf_mutex);
@@ -696,6 +697,13 @@ static struct ath10k_dump_file_data *ath10k_build_dump_file(struct ath10k *ar)
memcpy(dump_tlv->tlv_data, &ar->debug.stack_buf, dump_tlv->tlv_len);
sofar += sizeof(*dump_tlv) + dump_tlv->tlv_len;
+ /* Gather firmware exception (irq) stack dump */
+ dump_tlv = (struct ath10k_tlv_dump_data *)(buf + sofar);
+ dump_tlv->type = ATH10K_FW_ERROR_DUMP_EXC_STACK;
+ dump_tlv->tlv_len = sizeof(ar->debug.exc_stack_buf);
+ memcpy(dump_tlv->tlv_data, &ar->debug.exc_stack_buf, dump_tlv->tlv_len);
+ sofar += sizeof(*dump_tlv) + dump_tlv->tlv_len;
+
spin_unlock_irqrestore(&ar->data_lock, flags);
WARN_ON(sofar != len);
@@ -864,8 +864,15 @@ static void ath10k_save_firmware_stack(struct ath10k *ar)
ath10k_save_firmware_mem_helper(ar, ATH10K_FW_STACK_SIZE,
ar->debug.stack_buf, HI_ITEM(hi_stack));
}
-#endif
+/* Save the firmware exception stack */
+static void ath10k_save_firmware_exc_stack(struct ath10k *ar)
+{
+ ath10k_save_firmware_mem_helper(ar, ATH10K_FW_STACK_SIZE,
+ ar->debug.exc_stack_buf,
+ HI_ITEM(hi_err_stack));
+}
+#endif
static void ath10k_pci_hif_dump_area(struct ath10k *ar)
{
@@ -918,8 +925,10 @@ static void ath10k_pci_hif_dump_area(struct ath10k *ar)
#ifdef CONFIG_ATH10K_DEBUGFS
spin_lock_bh(&ar->data_lock);
- if (!ar->debug.crashed_since_read)
+ if (!ar->debug.crashed_since_read) {
ath10k_save_firmware_stack(ar);
+ ath10k_save_firmware_exc_stack(ar);
+ }
spin_unlock_bh(&ar->data_lock);