| Message ID | 1412890781-24160-1-git-send-email-hauke@hauke-m.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote: > Commit 2101e533f41a ("bcma: register bcma as device tree driver") > introduces a hard dependency on OF_ADDRESS into the bcma driver. > OF_ADDRESS is specifically disabled for the sparc architecture. > This results in the following error when building sparc64:allmodconfig. > > drivers/bcma/main.c: In function 'bcma_of_find_child_device': > drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' > > Fixes: 2101e533f41a ("bcma: register bcma as device tree driver") > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Much better than my patch. Reviewed-by: Guenter Roeck <linux@roeck-us.net> Also compile tested to make sure it fixes the build problem. Guenter > --- > drivers/bcma/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c > index d1656c2..1000955 100644 > --- a/drivers/bcma/main.c > +++ b/drivers/bcma/main.c > @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) > return false; > } > > -#ifdef CONFIG_OF > +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS) > static struct device_node *bcma_of_find_child_device(struct platform_device *parent, > struct bcma_device *core) > { > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote: > Commit 2101e533f41a ("bcma: register bcma as device tree driver") > introduces a hard dependency on OF_ADDRESS into the bcma driver. > OF_ADDRESS is specifically disabled for the sparc architecture. > This results in the following error when building sparc64:allmodconfig. > > drivers/bcma/main.c: In function 'bcma_of_find_child_device': > drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' > > Fixes: 2101e533f41a ("bcma: register bcma as device tree driver") > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> The upstream kernel still does not include this patch, and the sparc64 build is still broken. Is this patch on its way upstream ? Guenter > --- > drivers/bcma/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c > index d1656c2..1000955 100644 > --- a/drivers/bcma/main.c > +++ b/drivers/bcma/main.c > @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) > return false; > } > > -#ifdef CONFIG_OF > +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS) > static struct device_node *bcma_of_find_child_device(struct platform_device *parent, > struct bcma_device *core) > { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Yes, I have it queued. Things have been delayed due to my recent travels, etc. On Sat, Oct 25, 2014 at 01:36:53PM -0700, Guenter Roeck wrote: > On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote: > > Commit 2101e533f41a ("bcma: register bcma as device tree driver") > > introduces a hard dependency on OF_ADDRESS into the bcma driver. > > OF_ADDRESS is specifically disabled for the sparc architecture. > > This results in the following error when building sparc64:allmodconfig. > > > > drivers/bcma/main.c: In function 'bcma_of_find_child_device': > > drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' > > > > Fixes: 2101e533f41a ("bcma: register bcma as device tree driver") > > Reported-by: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > > The upstream kernel still does not include this patch, and the sparc64 build > is still broken. > > Is this patch on its way upstream ? > > Guenter > > > --- > > drivers/bcma/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c > > index d1656c2..1000955 100644 > > --- a/drivers/bcma/main.c > > +++ b/drivers/bcma/main.c > > @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) > > return false; > > } > > > > -#ifdef CONFIG_OF > > +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS) > > static struct device_node *bcma_of_find_child_device(struct platform_device *parent, > > struct bcma_device *core) > > { > > -- > > 1.9.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > >
On Mon, Oct 27, 2014 at 11:15:09AM -0400, John W. Linville wrote: > Yes, I have it queued. Things have been delayed due to my recent > travels, etc. > Thanks! Guenter > On Sat, Oct 25, 2014 at 01:36:53PM -0700, Guenter Roeck wrote: > > On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote: > > > Commit 2101e533f41a ("bcma: register bcma as device tree driver") > > > introduces a hard dependency on OF_ADDRESS into the bcma driver. > > > OF_ADDRESS is specifically disabled for the sparc architecture. > > > This results in the following error when building sparc64:allmodconfig. > > > > > > drivers/bcma/main.c: In function 'bcma_of_find_child_device': > > > drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' > > > > > > Fixes: 2101e533f41a ("bcma: register bcma as device tree driver") > > > Reported-by: Guenter Roeck <linux@roeck-us.net> > > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > > > > The upstream kernel still does not include this patch, and the sparc64 build > > is still broken. > > > > Is this patch on its way upstream ? > > > > Guenter > > > > > --- > > > drivers/bcma/main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c > > > index d1656c2..1000955 100644 > > > --- a/drivers/bcma/main.c > > > +++ b/drivers/bcma/main.c > > > @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) > > > return false; > > > } > > > > > > -#ifdef CONFIG_OF > > > +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS) > > > static struct device_node *bcma_of_find_child_device(struct platform_device *parent, > > > struct bcma_device *core) > > > { > > > -- > > > 1.9.1 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Please read the FAQ at http://www.tux.org/lkml/ > > > > > > > > > > -- > John W. Linville Someday the world will need a hero, and you > linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c index d1656c2..1000955 100644 --- a/drivers/bcma/main.c +++ b/drivers/bcma/main.c @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id) return false; } -#ifdef CONFIG_OF +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS) static struct device_node *bcma_of_find_child_device(struct platform_device *parent, struct bcma_device *core) {
Commit 2101e533f41a ("bcma: register bcma as device tree driver") introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS is specifically disabled for the sparc architecture. This results in the following error when building sparc64:allmodconfig. drivers/bcma/main.c: In function 'bcma_of_find_child_device': drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address' Fixes: 2101e533f41a ("bcma: register bcma as device tree driver") Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- drivers/bcma/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)