| Message ID | 1422341373-22196-4-git-send-email-plaes@plaes.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 01/27/2015 12:49 AM, Priit Laes wrote: > Signed-off-by: Priit Laes <plaes@plaes.org> > --- > drivers/net/wireless/rtlwifi/core.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/wireless/rtlwifi/core.h b/drivers/net/wireless/rtlwifi/core.h > index 624e1dc..3b37557 100644 > --- a/drivers/net/wireless/rtlwifi/core.h > +++ b/drivers/net/wireless/rtlwifi/core.h > @@ -33,8 +33,6 @@ > FIF_FCSFAIL | \ > FIF_BCN_PRBRESP_PROMISC) > > -#define RTL_SUPPORTED_CTRL_FILTER 0xFF > - > extern const struct ieee80211_ops rtl_ops; > void rtl_fw_cb(const struct firmware *firmware, void *context); > void rtl_addr_delay(u32 addr); Priit, I have a couple of points to make. First, when you submit a series of patches like this, it is customary to use the cover letter feature of git to generate a 0/X patch in which to explain the set of patches. In this case, the cover letter is not necessary, but it is a good habit to cultivate. The second point is more important. I'm not sure what source you used to generate your patches, but it was clearly not wireless-drivers-next. Commit 6f8214b69057 ("rtlwifi: Create new routine to initialize the DM tables") moved a lot of stuff from the individual drivers into the core. Some of the new stuff was included right after the definition of RTL_SUPPORTED_CTRL_FILTER, thus your patch fails to apply. Once you fix this problem, and resubmit V2 of the series, I will approve them. FYI, Kalle prefers that all patches be resubmitted, not just the one that changes. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rtlwifi/core.h b/drivers/net/wireless/rtlwifi/core.h index 624e1dc..3b37557 100644 --- a/drivers/net/wireless/rtlwifi/core.h +++ b/drivers/net/wireless/rtlwifi/core.h @@ -33,8 +33,6 @@ FIF_FCSFAIL | \ FIF_BCN_PRBRESP_PROMISC) -#define RTL_SUPPORTED_CTRL_FILTER 0xFF - extern const struct ieee80211_ops rtl_ops; void rtl_fw_cb(const struct firmware *firmware, void *context); void rtl_addr_delay(u32 addr);
Signed-off-by: Priit Laes <plaes@plaes.org> --- drivers/net/wireless/rtlwifi/core.h | 2 -- 1 file changed, 2 deletions(-)