| Message ID | 1422716904-5208-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> writes: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c > index 179a1ba..3cbbfb7 100644 > --- a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c > +++ b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c > @@ -743,10 +743,8 @@ static void _PHY_IQCalibrate(struct rtw_adapter *pAdapter, int result[][8], u8 t > /* Note: IQ calibration must be performed after loading */ > /* PHY_REG.txt , and radio_a, radio_b.txt */ > > - u32 bbvalue; > - > if (t == 0) { > - bbvalue = PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); > + PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); In this particular case, I'd say to get rid of the call completely. FPGA0_RFMOD should not have magic side effects just from being read. Jes > > /* Save ADDA parameters, turn Path A ADDA on */ > _PHY_SaveADDARegisters(pAdapter, ADDA_REG, pdmpriv->ADDA_backup, IQK_ADDA_REG_NUM); > @@ -1047,7 +1045,7 @@ void rtl8723a_phy_iq_calibrate(struct rtw_adapter *pAdapter, bool bReCovery) > bPathAOK = bPathBOK = true; > } else { > RegE94 = RegEB4 = pdmpriv->RegE94 = pdmpriv->RegEB4 = 0x100; /* X default value */ > - RegE9C = RegEBC = pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ > + pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ > } > > if ((RegE94 != 0)/*&&(RegEA4 != 0)*/) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-02-02 0:00 GMT+01:00 Jes Sorensen <Jes.Sorensen@redhat.com>: > Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> writes: >> Variable was assigned a value that was never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> >> --- >> drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c >> index 179a1ba..3cbbfb7 100644 >> --- a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c >> +++ b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c >> @@ -743,10 +743,8 @@ static void _PHY_IQCalibrate(struct rtw_adapter *pAdapter, int result[][8], u8 t >> /* Note: IQ calibration must be performed after loading */ >> /* PHY_REG.txt , and radio_a, radio_b.txt */ >> >> - u32 bbvalue; >> - >> if (t == 0) { >> - bbvalue = PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); >> + PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); > > In this particular case, I'd say to get rid of the call completely. > FPGA0_RFMOD should not have magic side effects just from being read. > > Jes > >> >> /* Save ADDA parameters, turn Path A ADDA on */ >> _PHY_SaveADDARegisters(pAdapter, ADDA_REG, pdmpriv->ADDA_backup, IQK_ADDA_REG_NUM); >> @@ -1047,7 +1045,7 @@ void rtl8723a_phy_iq_calibrate(struct rtw_adapter *pAdapter, bool bReCovery) >> bPathAOK = bPathBOK = true; >> } else { >> RegE94 = RegEB4 = pdmpriv->RegE94 = pdmpriv->RegEB4 = 0x100; /* X default value */ >> - RegE9C = RegEBC = pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ >> + pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ >> } >> >> if ((RegE94 != 0)/*&&(RegEA4 != 0)*/) Hi I am sorry, please ignore this. I will not send any more patches. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c index 179a1ba..3cbbfb7 100644 --- a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c +++ b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c @@ -743,10 +743,8 @@ static void _PHY_IQCalibrate(struct rtw_adapter *pAdapter, int result[][8], u8 t /* Note: IQ calibration must be performed after loading */ /* PHY_REG.txt , and radio_a, radio_b.txt */ - u32 bbvalue; - if (t == 0) { - bbvalue = PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); + PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); /* Save ADDA parameters, turn Path A ADDA on */ _PHY_SaveADDARegisters(pAdapter, ADDA_REG, pdmpriv->ADDA_backup, IQK_ADDA_REG_NUM); @@ -1047,7 +1045,7 @@ void rtl8723a_phy_iq_calibrate(struct rtw_adapter *pAdapter, bool bReCovery) bPathAOK = bPathBOK = true; } else { RegE94 = RegEB4 = pdmpriv->RegE94 = pdmpriv->RegEB4 = 0x100; /* X default value */ - RegE9C = RegEBC = pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ + pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ } if ((RegE94 != 0)/*&&(RegEA4 != 0)*/)
Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)