| Message ID | 1424887133-5670-1-git-send-email-ap420073@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 02/25/2015 11:58 AM, Taehee Yoo wrote: > rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process. > > Signed-off-by: Taehee Yoo <ap420073@gmail.com> Has this been tested? I am not aware that the RTL8192CU firmware could handle WOWLAN. Larry > --- > drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c > index fe4b699..f6ad959 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c > @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val) > case HW_VAR_DATA_FILTER: > *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2); > break; > + case HAL_DEF_WOWLAN: > + if (ppsc->wo_wlan_mode) > + *((bool *)(val)) = true; > + else > + *((bool *)(val)) = false; > + break; > default: > RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, > "switch case not processed\n"); > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-02-26 3:33 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>: > On 02/25/2015 11:58 AM, Taehee Yoo wrote: >> >> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process. >> >> Signed-off-by: Taehee Yoo <ap420073@gmail.com> > > > Has this been tested? I am not aware that the RTL8192CU firmware could > handle WOWLAN. > > Larry > > >> --- >> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >> index fe4b699..f6ad959 100644 >> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 >> variable, u8 *val) >> case HW_VAR_DATA_FILTER: >> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2); >> break; >> + case HAL_DEF_WOWLAN: >> + if (ppsc->wo_wlan_mode) >> + *((bool *)(val)) = true; >> + else >> + *((bool *)(val)) = false; >> + break; >> default: >> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, >> "switch case not processed\n"); >> > As far as i know, rtl8192cu is not support WOWLAN. in rtl8192cu, this code is no effect. so, It is care of unnecessary debug message. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/25/2015 12:59 PM, ap420073 . wrote: > 2015-02-26 3:33 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>: >> On 02/25/2015 11:58 AM, Taehee Yoo wrote: >>> >>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process. >>> >>> Signed-off-by: Taehee Yoo <ap420073@gmail.com> >> >> >> Has this been tested? I am not aware that the RTL8192CU firmware could >> handle WOWLAN. >> >> Larry >> >> >>> --- >>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>> index fe4b699..f6ad959 100644 >>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 >>> variable, u8 *val) >>> case HW_VAR_DATA_FILTER: >>> *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2); >>> break; >>> + case HAL_DEF_WOWLAN: >>> + if (ppsc->wo_wlan_mode) >>> + *((bool *)(val)) = true; >>> + else >>> + *((bool *)(val)) = false; >>> + break; >>> default: >>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, >>> "switch case not processed\n"); >>> >> > > As far as i know, rtl8192cu is not support WOWLAN. > in rtl8192cu, this code is no effect. so, It is care of unnecessary > debug message. That is what I thought. In that case, the new code should be case HAL_DEF_WOWLAN: break; Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-02-26 4:12 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>: > On 02/25/2015 12:59 PM, ap420073 . wrote: >> >> 2015-02-26 3:33 GMT+09:00 Larry Finger <Larry.Finger@lwfinger.net>: >>> >>> On 02/25/2015 11:58 AM, Taehee Yoo wrote: >>>> >>>> >>>> rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process. >>>> >>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com> >>> >>> >>> >>> Has this been tested? I am not aware that the RTL8192CU firmware could >>> handle WOWLAN. >>> >>> Larry >>> >>> >>>> --- >>>> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>>> b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>>> index fe4b699..f6ad959 100644 >>>> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>>> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c >>>> @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, >>>> u8 >>>> variable, u8 *val) >>>> case HW_VAR_DATA_FILTER: >>>> *((u16 *) (val)) = rtl_read_word(rtlpriv, >>>> REG_RXFLTMAP2); >>>> break; >>>> + case HAL_DEF_WOWLAN: >>>> + if (ppsc->wo_wlan_mode) >>>> + *((bool *)(val)) = true; >>>> + else >>>> + *((bool *)(val)) = false; >>>> + break; >>>> default: >>>> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, >>>> "switch case not processed\n"); >>>> >>> >> >> As far as i know, rtl8192cu is not support WOWLAN. >> in rtl8192cu, this code is no effect. so, It is care of unnecessary >> debug message. > > > That is what I thought. In that case, the new code should be > > case HAL_DEF_WOWLAN: > break; > > Larry > Thanks! I would send a new code. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c index fe4b699..f6ad959 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c @@ -1589,6 +1589,12 @@ void rtl92cu_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val) case HW_VAR_DATA_FILTER: *((u16 *) (val)) = rtl_read_word(rtlpriv, REG_RXFLTMAP2); break; + case HAL_DEF_WOWLAN: + if (ppsc->wo_wlan_mode) + *((bool *)(val)) = true; + else + *((bool *)(val)) = false; + break; default: RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, "switch case not processed\n");
rtl_op_stop get wowlan state but rtl92cu_get_hw_reg has not process. Signed-off-by: Taehee Yoo <ap420073@gmail.com> --- drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 6 ++++++ 1 file changed, 6 insertions(+)