| Message ID | 1425364377-12771-1-git-send-email-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
Rafa? Mi?ecki <zajec5@gmail.com> writes: > Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com> Please, no empty commit logs. I don't (yet) require that with all patches, but this definitely needs one. Is this ok: bcma: add missing includes kbuild found out that commit 804e27dee49e ("bcma: support bringing up bus hosted on PCIe Gen 2") broke the build on m68k: drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up': >> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\ =implicit-function-declaration] err = pcie_set_readrq(dev, pcie2->reqsize); ^ cc1: some warnings being treated as errors Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
On 3 March 2015 at 13:14, Kalle Valo <kvalo@codeaurora.org> wrote: > Rafa? Mi?ecki <zajec5@gmail.com> writes: > >> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com> > > Please, no empty commit logs. I don't (yet) require that with all > patches, but this definitely needs one. Is this ok: > > bcma: add missing includes > > kbuild found out that commit 804e27dee49e ("bcma: support bringing up > bus hosted on PCIe Gen 2") broke the build on m68k: > > drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up': >>> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\ > =implicit-function-declaration] > err = pcie_set_readrq(dev, pcie2->reqsize); > ^ > cc1: some warnings being treated as errors > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com> You're right, I could to better :| Yes, your version looks OK.
Rafa? Mi?ecki <zajec5@gmail.com> writes: > On 3 March 2015 at 13:14, Kalle Valo <kvalo@codeaurora.org> wrote: >> Rafa? Mi?ecki <zajec5@gmail.com> writes: >> >>> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com> >> >> Please, no empty commit logs. I don't (yet) require that with all >> patches, but this definitely needs one. Is this ok: >> >> bcma: add missing includes >> >> kbuild found out that commit 804e27dee49e ("bcma: support bringing up >> bus hosted on PCIe Gen 2") broke the build on m68k: >> >> drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up': >>>> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\ >> =implicit-function-declaration] >> err = pcie_set_readrq(dev, pcie2->reqsize); >> ^ >> cc1: some warnings being treated as errors >> >> Reported-by: kbuild test robot <fengguang.wu@intel.com> >> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com> > > You're right, I could to better :| Yes, your version looks OK. Thanks, I applied with my modifications.
diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c index c8a6b74..c42cec7 100644 --- a/drivers/bcma/driver_pci_host.c +++ b/drivers/bcma/driver_pci_host.c @@ -11,6 +11,7 @@ #include "bcma_private.h" #include <linux/pci.h> +#include <linux/slab.h> #include <linux/export.h> #include <linux/bcma/bcma.h> #include <asm/paccess.h> diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c index 4568bc7..b1a6e32 100644 --- a/drivers/bcma/driver_pcie2.c +++ b/drivers/bcma/driver_pcie2.c @@ -10,6 +10,7 @@ #include "bcma_private.h" #include <linux/bcma/bcma.h> +#include <linux/pci.h> /************************************************** * R/W ops.
Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com> --- drivers/bcma/driver_pci_host.c | 1 + drivers/bcma/driver_pcie2.c | 1 + 2 files changed, 2 insertions(+)