diff mbox

[3/9] mwifiex: enhance SD8897 MP aggregation limits

Message ID 1426180920-10567-4-git-send-email-patila@marvell.com (mailing list archive)
State Superseded
Delegated to: Kalle Valo
Headers show

Commit Message

Avinash Patil March 12, 2015, 5:21 p.m. UTC
SD8897 support buffers of 4K and 16 such ports can be accomodated.
So basically 64K buffer size in single aggregation is supported.

Signed-off-by: Avinash Patil <patila@marvell.com>
---
 drivers/net/wireless/mwifiex/sdio.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Bjørn Mork March 12, 2015, 1:07 p.m. UTC | #1
Avinash Patil <patila@marvell.com> writes:

> diff --git a/drivers/net/wireless/mwifiex/sdio.h b/drivers/net/wireless/mwifiex/sdio.h
> index c636944..5a23bd0 100644
> --- a/drivers/net/wireless/mwifiex/sdio.h
> +++ b/drivers/net/wireless/mwifiex/sdio.h
> @@ -67,6 +67,7 @@
>  
>  #define MWIFIEX_MP_AGGR_BUF_SIZE_16K	(16384)
>  #define MWIFIEX_MP_AGGR_BUF_SIZE_32K	(32768)
> +#define MWIFIEX_MP_AGGR_BUF_SIZE_64K    (65280)

The first two macros are clearly matching their 16K and 32K names, but
the 64K one is not.  Care to add a comment explaining where the missing
256 bytes went?


Bjørn (always curious about surprising numbers :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Avinash Patil March 13, 2015, 4:15 a.m. UTC | #2
SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQmrDuHJuIE1vcmsg
W21haWx0bzpiam9ybkBtb3JrLm5vXQ0KPiBTZW50OiBUaHVyc2RheSwgTWFyY2ggMTIsIDIwMTUg
NjozOCBQTQ0KPiBUbzogQXZpbmFzaCBQYXRpbA0KPiBDYzogbGludXgtd2lyZWxlc3NAdmdlci5r
ZXJuZWwub3JnOyBBbWl0a3VtYXIgS2Fyd2FyOyBDYXRoeSBMdW87IFpoYW95YW5nIExpdTsNCj4g
Q2hpbi1SYW4gTG87IFBsdXMgQ2hlbjsgU2hlbmd6aGVuIExpOyBOaXNoYW50IFNhcm11a2FkYW0N
Cj4gU3ViamVjdDogUmU6IFtQQVRDSCAzLzldIG13aWZpZXg6IGVuaGFuY2UgU0Q4ODk3IE1QIGFn
Z3JlZ2F0aW9uIGxpbWl0cw0KPiANCj4gQXZpbmFzaCBQYXRpbCA8cGF0aWxhQG1hcnZlbGwuY29t
PiB3cml0ZXM6DQo+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9td2lm
aWV4L3NkaW8uaA0KPiA+IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC9zZGlvLmgNCj4g
PiBpbmRleCBjNjM2OTQ0Li41YTIzYmQwIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvbmV0L3dp
cmVsZXNzL213aWZpZXgvc2Rpby5oDQo+ID4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdp
ZmlleC9zZGlvLmgNCj4gPiBAQCAtNjcsNiArNjcsNyBAQA0KPiA+DQo+ID4gICNkZWZpbmUgTVdJ
RklFWF9NUF9BR0dSX0JVRl9TSVpFXzE2SwkoMTYzODQpDQo+ID4gICNkZWZpbmUgTVdJRklFWF9N
UF9BR0dSX0JVRl9TSVpFXzMySwkoMzI3NjgpDQo+ID4gKyNkZWZpbmUgTVdJRklFWF9NUF9BR0dS
X0JVRl9TSVpFXzY0SyAgICAoNjUyODApDQo+IA0KPiBUaGUgZmlyc3QgdHdvIG1hY3JvcyBhcmUg
Y2xlYXJseSBtYXRjaGluZyB0aGVpciAxNksgYW5kIDMySyBuYW1lcywgYnV0IHRoZSA2NEsNCj4g
b25lIGlzIG5vdC4gIENhcmUgdG8gYWRkIGEgY29tbWVudCBleHBsYWluaW5nIHdoZXJlIHRoZSBt
aXNzaW5nDQo+IDI1NiBieXRlcyB3ZW50Pw0KDQpXZSByZXNlcnZlIGZpcnN0IGJsb2NrIG9mIDI1
NiBieXRlcyBmb3IgRE1BIGFsaWdubWVudC4NCkkgd2lsbCBhZGQgYSBjb21tZW50IHRvIGRlZmlu
aXRpb247IGFsc28gcmVuYW1lIGRlZmluZSBzaW5jZSBpdCBpcyBub3QgZXhhY3RseSA2NEsuDQog
DQo+IEJqw7hybiAoYWx3YXlzIGN1cmlvdXMgYWJvdXQgc3VycHJpc2luZyBudW1iZXJzIDotKQ0K
DQotQXZpbmFzaA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/mwifiex/sdio.h b/drivers/net/wireless/mwifiex/sdio.h
index c636944..5a23bd0 100644
--- a/drivers/net/wireless/mwifiex/sdio.h
+++ b/drivers/net/wireless/mwifiex/sdio.h
@@ -67,6 +67,7 @@ 
 
 #define MWIFIEX_MP_AGGR_BUF_SIZE_16K	(16384)
 #define MWIFIEX_MP_AGGR_BUF_SIZE_32K	(32768)
+#define MWIFIEX_MP_AGGR_BUF_SIZE_64K    (65280)
 
 /* Misc. Config Register : Auto Re-enable interrupts */
 #define AUTO_RE_ENABLE_INT              BIT(4)
@@ -458,8 +459,8 @@  static const struct mwifiex_sdio_device mwifiex_sdio_sd8897 = {
 	.max_ports = 32,
 	.mp_agg_pkt_limit = 16,
 	.tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K,
-	.mp_tx_agg_buf_size = MWIFIEX_MP_AGGR_BUF_SIZE_32K,
-	.mp_rx_agg_buf_size = MWIFIEX_MP_AGGR_BUF_SIZE_32K,
+	.mp_tx_agg_buf_size = MWIFIEX_MP_AGGR_BUF_SIZE_64K,
+	.mp_rx_agg_buf_size = MWIFIEX_MP_AGGR_BUF_SIZE_64K,
 	.supports_sdio_new_mode = true,
 	.has_control_mask = false,
 	.can_dump_fw = true,