diff mbox

[v2,2/2] ath9k: fix incorrect calibration initial for ar9561

Message ID 1440033699-11121-2-git-send-email-miaoqing@qca.qualcomm.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

miaoqing pan Aug. 20, 2015, 1:21 a.m. UTC 
From: Miaoqing Pan <miaoqing@qca.qualcomm.com>

One stuck issue was found on AP152, the root cause is using wrong
calibration initial function.

Signed-off-by: Miaoqing Pan <miaoqing@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/ar9003_calib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Sujith Manoharan Aug. 20, 2015, 3:47 a.m. UTC | #1 
miaoqing@qti.qualcomm.com wrote:
> -	if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah))
> +	if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah) ||
> +	    AR_SREV_9561(ah))
>  		priv_ops->init_cal = ar9003_hw_init_cal_pcoem;
>  	else
>  		priv_ops->init_cal = ar9003_hw_init_cal_soc;

Are you sure about this ? AR9561 is not a PCOEM chip, IIRC.
Maybe the SoC routine is missing some code changes for AR956x ?

Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
miaoqing pan Aug. 20, 2015, 7:07 a.m. UTC | #2 
Thanks Sujith.  You mentioned this before,  so need more investigation,  and this patch will be discarded. 

Miaoqing

-----Original Message-----
From: Sujith Manoharan [mailto:sujith@msujith.org] 
Sent: Thursday, August 20, 2015 11:47 AM
To: Pan, Miaoqing
Cc: linville@tuxdriver.com; linux-wireless@vger.kernel.org; ath9k-devel; Valo, Kalle
Subject: Re: [PATCH v2 2/2] ath9k: fix incorrect calibration initial for ar9561

miaoqing@qti.qualcomm.com wrote:
> -	if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah))
> +	if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah) ||
> +	    AR_SREV_9561(ah))
>  		priv_ops->init_cal = ar9003_hw_init_cal_pcoem;
>  	else
>  		priv_ops->init_cal = ar9003_hw_init_cal_soc;

Are you sure about this ? AR9561 is not a PCOEM chip, IIRC.
Maybe the SoC routine is missing some code changes for AR956x ?

Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
index 174442b..3880df7 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
@@ -1310,7 +1310,8 @@  static void ar9003_hw_do_pcoem_manual_peak_cal(struct ath_hw *ah,
 	struct ath9k_hw_cal_data *caldata = ah->caldata;
 	int i;
 
-	if (!AR_SREV_9462(ah) && !AR_SREV_9565(ah) && !AR_SREV_9485(ah))
+	if (!AR_SREV_9462(ah) && !AR_SREV_9565(ah) && !AR_SREV_9485(ah) &&
+	    !AR_SREV_9561(ah))
 		return;
 
 	if ((ah->caps.hw_caps & ATH9K_HW_CAP_RTT) && !run_rtt_cal)
@@ -1707,7 +1708,8 @@  void ar9003_hw_attach_calib_ops(struct ath_hw *ah)
 	struct ath_hw_private_ops *priv_ops = ath9k_hw_private_ops(ah);
 	struct ath_hw_ops *ops = ath9k_hw_ops(ah);
 
-	if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah))
+	if (AR_SREV_9485(ah) || AR_SREV_9462(ah) || AR_SREV_9565(ah) ||
+	    AR_SREV_9561(ah))
 		priv_ops->init_cal = ar9003_hw_init_cal_pcoem;
 	else
 		priv_ops->init_cal = ar9003_hw_init_cal_soc;