| Message ID | 1441912470-3371-1-git-send-email-chaehyun.lim@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Fri, Sep 11, 2015 at 04:14:00AM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_CfgSetChannel with > wilc_set_channel to avoid CamelCase. > > Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> > --- > V2: to make function name simple > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > index cf76a33..3149fd8 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > @@ -677,7 +677,7 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent, > > > /** > - * @brief WILC_WFI_CfgSetChannel > + * @brief wilc_set_channel > * @details Set channel for a given wireless interface. Some devices > * may support multi-channel operation (by channel hopping) so cfg80211 > * doesn't verify much. Note, however, that the passed netdev may be > @@ -689,8 +689,8 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent, > * @date 01 MAR 2012 > * @version 1.0 > */ > -static int WILC_WFI_CfgSetChannel(struct wiphy *wiphy, > - struct cfg80211_chan_def *chandef) > +static int wilc_set_channel(struct wiphy *wiphy, > + struct cfg80211_chan_def *chandef) static functions do not need a "wilc_" prefix. Just name it "set_channel()" Can you redo this series based on that, rebase on my staging-testing git branch as things are changing fast in this driver, and then resend? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index cf76a33..3149fd8 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -677,7 +677,7 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent, /** - * @brief WILC_WFI_CfgSetChannel + * @brief wilc_set_channel * @details Set channel for a given wireless interface. Some devices * may support multi-channel operation (by channel hopping) so cfg80211 * doesn't verify much. Note, however, that the passed netdev may be @@ -689,8 +689,8 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent, * @date 01 MAR 2012 * @version 1.0 */ -static int WILC_WFI_CfgSetChannel(struct wiphy *wiphy, - struct cfg80211_chan_def *chandef) +static int wilc_set_channel(struct wiphy *wiphy, + struct cfg80211_chan_def *chandef) { u32 channelnum = 0; @@ -3230,7 +3230,7 @@ static int WILC_WFI_start_ap(struct wiphy *wiphy, struct net_device *dev, PRINT_D(HOSTAPD_DBG, "Interval = %d\n DTIM period = %d\n Head length = %zu Tail length = %zu\n", settings->beacon_interval, settings->dtim_period, beacon->head_len, beacon->tail_len); - s32Error = WILC_WFI_CfgSetChannel(wiphy, &settings->chandef); + s32Error = wilc_set_channel(wiphy, &settings->chandef); if (s32Error != WILC_SUCCESS) PRINT_ER("Error in setting channel\n"); @@ -3558,7 +3558,7 @@ int WILC_WFI_del_virt_intf(struct wiphy *wiphy, struct wireless_dev *wdev) #endif /*WILC_AP_EXTERNAL_MLME*/ static struct cfg80211_ops WILC_WFI_cfg80211_ops = { - .set_monitor_channel = WILC_WFI_CfgSetChannel, + .set_monitor_channel = wilc_set_channel, .scan = WILC_WFI_CfgScan, .connect = WILC_WFI_CfgConnect, .disconnect = WILC_WFI_disconnect,
This patch replaces WILC_WFI_CfgSetChannel with wilc_set_channel to avoid CamelCase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> --- V2: to make function name simple drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)