diff mbox

[09/12] ath9k: request NOA update when chanctx active

Message ID 1447334149-15507-9-git-send-email-janusz.dziedzic@tieto.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

Janusz.Dziedzic@tieto.com Nov. 12, 2015, 1:15 p.m. UTC
Request NOA update when chanctx active, also in case
of STA.

Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
---
This depends on:
[PATCH] mac80211: add new IEEE80211_VIF_GET_NOA_UPDATE flag

 drivers/net/wireless/ath/ath9k/channel.c | 2 +-
 drivers/net/wireless/ath/ath9k/main.c    | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

kernel test robot Nov. 12, 2015, 1:59 p.m. UTC | #1
Hi Janusz,

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.3 next-20151112]

url:    https://github.com/0day-ci/linux/commits/Janusz-Dziedzic/ath9k-add-debug-messages-to-aggr-chanctx-funcs/20151112-212004
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net/wireless/ath/ath9k/main.c: In function 'ath9k_add_interface':
>> drivers/net/wireless/ath/ath9k/main.c:1255:24: error: 'IEEE80211_VIF_GET_NOA_UPDATE' undeclared (first use in this function)
      vif->driver_flags |= IEEE80211_VIF_GET_NOA_UPDATE;
                           ^
   drivers/net/wireless/ath/ath9k/main.c:1255:24: note: each undeclared identifier is reported only once for each function it appears in

vim +/IEEE80211_VIF_GET_NOA_UPDATE +1255 drivers/net/wireless/ath/ath9k/main.c

  1249		}
  1250	
  1251		ath_dbg(common, CONFIG, "Attach a VIF of type: %d\n", vif->type);
  1252		sc->cur_chan->nvifs++;
  1253	
  1254		if (vif->type == NL80211_IFTYPE_STATION && ath9k_is_chanctx_enabled())
> 1255			vif->driver_flags |= IEEE80211_VIF_GET_NOA_UPDATE;
  1256	
  1257		if (ath9k_uses_beacons(vif->type))
  1258			ath9k_beacon_assign_slot(sc, vif);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
index db49bc5..4320928 100644
--- a/drivers/net/wireless/ath/ath9k/channel.c
+++ b/drivers/net/wireless/ath/ath9k/channel.c
@@ -1439,7 +1439,7 @@  static void ath9k_update_p2p_ps(struct ath_softc *sc, struct ieee80211_vif *vif)
 	if (!sc->p2p_ps_timer)
 		return;
 
-	if (vif->type != NL80211_IFTYPE_STATION || !vif->p2p)
+	if (vif->type != NL80211_IFTYPE_STATION)
 		return;
 
 	sc->p2p_ps_vif = avp;
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index d184e68..ab46a4d 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -974,7 +974,7 @@  static void ath9k_update_bssid_mask(struct ath_softc *sc,
 		if (ctx->nvifs_assigned != 1)
 			continue;
 
-		if (!avp->vif->p2p || !iter_data->has_hw_macaddr)
+		if (!iter_data->has_hw_macaddr)
 			continue;
 
 		ether_addr_copy(common->curbssid, avp->bssid);
@@ -1251,6 +1251,9 @@  static int ath9k_add_interface(struct ieee80211_hw *hw,
 	ath_dbg(common, CONFIG, "Attach a VIF of type: %d\n", vif->type);
 	sc->cur_chan->nvifs++;
 
+	if (vif->type == NL80211_IFTYPE_STATION && ath9k_is_chanctx_enabled())
+		vif->driver_flags |= IEEE80211_VIF_GET_NOA_UPDATE;
+
 	if (ath9k_uses_beacons(vif->type))
 		ath9k_beacon_assign_slot(sc, vif);