diff mbox

[3/8] staging: vt6655: set_channel replace bResult with ret

Message ID 1448183242-3397-3-git-send-email-tvboxspy@gmail.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Malcolm Priestley Nov. 22, 2015, 9:07 a.m. UTC 
Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6655/channel.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Julian Calaby Nov. 23, 2015, 12:31 a.m. UTC | #1 
Hi Malcolm,

On Sun, Nov 22, 2015 at 8:07 PM, Malcolm Priestley <tvboxspy@gmail.com> wrote:
> Removing camel case.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
>  drivers/staging/vt6655/channel.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
> index d1c9116..9ac1ef9 100644
> --- a/drivers/staging/vt6655/channel.c
> +++ b/drivers/staging/vt6655/channel.c
> @@ -176,10 +176,10 @@ void vnt_init_bands(struct vnt_private *priv)
>   */
>  bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
>  {
> -       bool bResult = true;
> +       bool ret = true;
>
>         if (priv->byCurrentCh == ch->hw_value)
> -               return bResult;
> +               return ret;

ret is always true here, right?

>
>         /* Set VGA to max sensitivity */
>         if (priv->bUpdateBBVGA &&
> @@ -200,8 +200,8 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
>                                                   ch->hw_value);
>
>         priv->byCurrentCh = ch->hw_value;
> -       bResult &= RFbSelectChannel(priv, priv->byRFType,
> -                                   ch->hw_value);
> +       ret &= RFbSelectChannel(priv, priv->byRFType,
> +                               ch->hw_value);

Isn't a &= b equivalent to a = a & b which is inappropriate for
boolean variables?

Also, wouldn't ret be true here, so the & is unnecessary?

Thanks,
diff mbox

Patch

diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index d1c9116..9ac1ef9 100644
--- a/drivers/staging/vt6655/channel.c
+++ b/drivers/staging/vt6655/channel.c
@@ -176,10 +176,10 @@  void vnt_init_bands(struct vnt_private *priv)
  */
 bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
 {
-	bool bResult = true;
+	bool ret = true;
 
 	if (priv->byCurrentCh == ch->hw_value)
-		return bResult;
+		return ret;
 
 	/* Set VGA to max sensitivity */
 	if (priv->bUpdateBBVGA &&
@@ -200,8 +200,8 @@  bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
 						  ch->hw_value);
 
 	priv->byCurrentCh = ch->hw_value;
-	bResult &= RFbSelectChannel(priv, priv->byRFType,
-				    ch->hw_value);
+	ret &= RFbSelectChannel(priv, priv->byRFType,
+				ch->hw_value);
 
 	/* Init Synthesizer Table */
 	if (priv->bEnablePSMode)
@@ -232,5 +232,5 @@  bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
 	else
 		RFbSetPower(priv, RATE_6M, priv->byCurrentCh);
 
-	return bResult;
+	return ret;
 }