| Message ID | 1450432137-30668-1-git-send-email-pawel.kulakowski@tieto.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Kalle Valo |
| Headers | show |
Pawel Kulakowski <pawel.kulakowski@tieto.com> writes: > Ath9k driver does not modify tx skbs, so SUPPORTS_CLONED_SKBS > flag can be set. Enabling this flag significant reduce number > of copy operation during TCP Tx. This is especially noticeable > on platforms with slower CPU (lower CPU usage brings > profits in better TCP Tx troughput results). > > Tested on MIPS with 560 MHz clock > Without CLONED_SKBS flag: > TCP Tx 145 Mb/s (iperf result) > __copy_user_common consumes 12.9% of CPU (result from perf tool) > 0% CPU Idle > > With CLONED_SKBS flag: > TCP Tx 170 Mb/s (iperf result) > __copy_user_common consumes 1.8% of CPU (result from perf tool) > 12% CPU Idle > > Signed-off-by: Pawel Kulakowski <pawel.kulakowski@tieto.com> Applied to ath.git, thanks.
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index 2e2b92b..ab7a1ac 100644 --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -828,6 +828,7 @@ static void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw) ieee80211_hw_set(hw, RX_INCLUDES_FCS); ieee80211_hw_set(hw, HOST_BROADCAST_PS_BUFFERING); ieee80211_hw_set(hw, SUPPORT_FAST_XMIT); + ieee80211_hw_set(hw, SUPPORTS_CLONED_SKBS); if (ath9k_ps_enable) ieee80211_hw_set(hw, SUPPORTS_PS);
Ath9k driver does not modify tx skbs, so SUPPORTS_CLONED_SKBS flag can be set. Enabling this flag significant reduce number of copy operation during TCP Tx. This is especially noticeable on platforms with slower CPU (lower CPU usage brings profits in better TCP Tx troughput results). Tested on MIPS with 560 MHz clock Without CLONED_SKBS flag: TCP Tx 145 Mb/s (iperf result) __copy_user_common consumes 12.9% of CPU (result from perf tool) 0% CPU Idle With CLONED_SKBS flag: TCP Tx 170 Mb/s (iperf result) __copy_user_common consumes 1.8% of CPU (result from perf tool) 12% CPU Idle Signed-off-by: Pawel Kulakowski <pawel.kulakowski@tieto.com> --- drivers/net/wireless/ath/ath9k/init.c | 1 + 1 file changed, 1 insertion(+)