| Message ID | 1458547622-1632-1-git-send-email-wnhuang@google.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Tested-by: Wei-Ning Huang <wnhuang@chromium.org> On Mon, Mar 21, 2016 at 4:07 PM, Wei-Ning Huang <wnhuang@chromium.org> wrote: > From: Amitkumar Karwar <akarwar@marvell.com> > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The reason > is firmware already takes care of it in our new feature scan > channel gap. Hence we should advertise low priority scan > support to cfg80211. > > This patch fixes a problem in which OBSS scan request from > wpa_supplicant was being rejected by cfg80211. > > Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org> > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index bb7235e..7dafc5b 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter) > > wiphy->features |= NL80211_FEATURE_HT_IBSS | > NL80211_FEATURE_INACTIVITY_TIMER | > + NL80211_FEATURE_LOW_PRIORITY_SCAN | > NL80211_FEATURE_NEED_OBSS_SCAN; > > if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info)) > -- > 2.8.0.rc3.226.g39d4020 >
> From: linux-wireless-owner@vger.kernel.org [mailto:linux-wireless- > owner@vger.kernel.org] On Behalf Of Wei-Ning Huang > Sent: Monday, March 21, 2016 1:37 PM > To: Linux Wireless > Cc: LKML; Amitkumar Karwar; djkurtz@chromium.org; Wei-Ning Huang; > Nishant Sarmukadam; kvalo@codeaurora.org; netdev@vger.kernel.org > Subject: [PATCH] mwifiex: advertise low priority scan feature > > From: Amitkumar Karwar <akarwar@marvell.com> > > Low priority scan handling code which delays or aborts scan operation > based on Tx traffic is removed recently. The reason is firmware already > takes care of it in our new feature scan channel gap. Hence we should > advertise low priority scan support to cfg80211. > > This patch fixes a problem in which OBSS scan request from > wpa_supplicant was being rejected by cfg80211. > > Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org> > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index bb7235e..7dafc5b 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct > mwifiex_adapter *adapter) > > wiphy->features |= NL80211_FEATURE_HT_IBSS | > NL80211_FEATURE_INACTIVITY_TIMER | > + NL80211_FEATURE_LOW_PRIORITY_SCAN | > NL80211_FEATURE_NEED_OBSS_SCAN; > > if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info)) Acked-by: Amitkumar Karwar <akarwar@marvell.com> Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Wei-Ning Huang <wnhuang@chromium.org> writes: > From: Amitkumar Karwar <akarwar@marvell.com> > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The reason > is firmware already takes care of it in our new feature scan > channel gap. Hence we should advertise low priority scan > support to cfg80211. > > This patch fixes a problem in which OBSS scan request from > wpa_supplicant was being rejected by cfg80211. > > Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org> The From line states that this is written by Amitkumar but there's no Signed-off-By line from him. I can't take this without that, please resend. (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.)
Hi Kalle, Thanks for the review. I accidentally removed the s-o-b line from akarwar in this version. The original patch can be found at: https://chromium-review.googlesource.com/#/c/246052/ I've resent a new one. Wei-Ning On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Wei-Ning Huang <wnhuang@chromium.org> writes: > >> From: Amitkumar Karwar <akarwar@marvell.com> >> >> Low priority scan handling code which delays or aborts scan >> operation based on Tx traffic is removed recently. The reason >> is firmware already takes care of it in our new feature scan >> channel gap. Hence we should advertise low priority scan >> support to cfg80211. >> >> This patch fixes a problem in which OBSS scan request from >> wpa_supplicant was being rejected by cfg80211. >> >> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org> > > The From line states that this is written by Amitkumar but there's no > Signed-off-By line from him. I can't take this without that, please > resend. > > (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) > > -- > Kalle Valo
I've resent the patch here: https://patchwork.kernel.org/patch/8637861/ Thanks! Wei-Ning On Tue, Mar 22, 2016 at 12:12 PM, Wei-Ning Huang <wnhuang@google.com> wrote: > Hi Kalle, > > Thanks for the review. I accidentally removed the s-o-b line from > akarwar in this version. > The original patch can be found at: > https://chromium-review.googlesource.com/#/c/246052/ > I've resent a new one. > > Wei-Ning > > On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >> Wei-Ning Huang <wnhuang@chromium.org> writes: >> >>> From: Amitkumar Karwar <akarwar@marvell.com> >>> >>> Low priority scan handling code which delays or aborts scan >>> operation based on Tx traffic is removed recently. The reason >>> is firmware already takes care of it in our new feature scan >>> channel gap. Hence we should advertise low priority scan >>> support to cfg80211. >>> >>> This patch fixes a problem in which OBSS scan request from >>> wpa_supplicant was being rejected by cfg80211. >>> >>> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org> >> >> The From line states that this is written by Amitkumar but there's no >> Signed-off-By line from him. I can't take this without that, please >> resend. >> >> (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) >> >> -- >> Kalle Valo > > > > -- > Wei-Ning Huang, ??? | Software Engineer, Google Inc., Taiwan | > wnhuang@google.com | Cell: +886 910-380678
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index bb7235e..7dafc5b 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter) wiphy->features |= NL80211_FEATURE_HT_IBSS | NL80211_FEATURE_INACTIVITY_TIMER | + NL80211_FEATURE_LOW_PRIORITY_SCAN | NL80211_FEATURE_NEED_OBSS_SCAN; if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))