| Message ID | 1464358702-19083-7-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 213d9421c165973f6cc9d79e91c8be2de25d0ea0 |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The function can fail so the returned value should be checked > and the error propagated to the caller in case of a failure. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.calaby@gmail.com> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks,
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index 1ffbb972318f..1c17e624547a 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -187,8 +187,13 @@ mwifiex_sdio_probe(struct sdio_func *func, const struct sdio_device_id *id) } /* device tree node parsing and platform specific configuration*/ - if (func->dev.of_node) - mwifiex_sdio_probe_of(&func->dev, card); + if (func->dev.of_node) { + ret = mwifiex_sdio_probe_of(&func->dev, card); + if (ret) { + dev_err(&func->dev, "SDIO dt node parse failed\n"); + goto err_disable; + } + } ret = mwifiex_add_card(card, &add_remove_card_sem, &sdio_ops, MWIFIEX_SDIO);
The function can fail so the returned value should be checked and the error propagated to the caller in case of a failure. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)