| Message ID | 1466294168-8890-1-git-send-email-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 20856adf22800ef90760d8256b6cf88675709584 |
| Delegated to: | Kalle Valo |
| Headers | show |
Rafał Miłecki wrote: > We obviously don't want to fall through in that switch. With this change > 1) We wait for event (triggered by p2p_disc) as expected > 2) We remove interface manually on timeout > 3) We return 0 on success instead of -ENOTSUPP > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> Thanks, 1 patch applied to wireless-drivers-next.git: 20856adf2280 brcmfmac: add missing break when deleting P2P_DEVICE
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index 426ff05..f6241fd 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -2261,6 +2261,8 @@ int brcmf_p2p_del_vif(struct wiphy *wiphy, struct wireless_dev *wdev) return 0; brcmf_p2p_cancel_remain_on_channel(vif->ifp); brcmf_p2p_deinit_discovery(p2p); + break; + default: return -ENOTSUPP; }
We obviously don't want to fall through in that switch. With this change 1) We wait for event (triggered by p2p_disc) as expected 2) We remove interface manually on timeout 3) We return 0 on success instead of -ENOTSUPP Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 ++ 1 file changed, 2 insertions(+)