| Message ID | 1467371245-5426-1-git-send-email-vthiagar@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi All, On Fri, Jul 1, 2016 at 9:07 PM, Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> wrote: > As hw cycle counters in QCA4019 wraparound independantly in QCA4019 > it is possible cycle counter and rx clear counter would wraparound > at the same time. Current logic assumes only one of the counters > would wraparound at anytime. Fix this by moving 'else' part to > another 'if'. > > Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019") > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> Looks right to me. Reviewed-by: Julian Calaby <julian.calaby@gmail.com> Thanks,
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> wrote: > As hw cycle counters in QCA4019 wraparound independantly in QCA4019 > it is possible cycle counter and rx clear counter would wraparound > at the same time. Current logic assumes only one of the counters > would wraparound at anytime. Fix this by moving 'else' part to > another 'if'. > > Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019") > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> > Reviewed-by: Julian Calaby <julian.calaby@gmail.com> Thanks, 1 patch applied to ath-next branch of ath.git: c11e99396d0f ath10k: fix possible wrong rx_busy time reporting in QCA4019
diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c index bd86e7a..7462627 100644 --- a/drivers/net/wireless/ath/ath10k/hw.c +++ b/drivers/net/wireless/ath/ath10k/hw.c @@ -198,7 +198,8 @@ void ath10k_hw_fill_survey_time(struct ath10k *ar, struct survey_info *survey, case ATH10K_HW_CC_WRAP_SHIFTED_EACH: if (cc < cc_prev) cc_fix = 0x7fffffff; - else + + if (rcc < rcc_prev) rcc_fix = 0x7fffffff; break; case ATH10K_HW_CC_WRAP_DISABLED:
As hw cycle counters in QCA4019 wraparound independantly in QCA4019 it is possible cycle counter and rx clear counter would wraparound at the same time. Current logic assumes only one of the counters would wraparound at anytime. Fix this by moving 'else' part to another 'if'. Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019") Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)