| Message ID | 1469088884-28469-1-git-send-email-rajan.vaja@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8432ebd66205ef1e088005ae3738600dedc7d9b4 |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi All, On Thu, Jul 21, 2016 at 6:14 PM, Rajan Vaja <rajan.vaja@gmail.com> wrote: > Fix coccicheck warning which recommends to > use memdup_user() instead of reimplementing its > code. > > This patch fixes below coccicheck warnings: > > drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3044:9-16: WARNING > opportunity for memdup_user > drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3806:9-16: WARNING > opportunity for memdup_user > > Signed-off-by: Rajan Vaja <rajan.vaja@gmail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.calaby@gmail.com> Thanks,
Rajan Vaja <rajan.vaja@gmail.com> wrote: > Fix coccicheck warning which recommends to > use memdup_user() instead of reimplementing its > code. > > This patch fixes below coccicheck warnings: > > drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3044:9-16: WARNING > opportunity for memdup_user > drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3806:9-16: WARNING > opportunity for memdup_user > > Signed-off-by: Rajan Vaja <rajan.vaja@gmail.com> > Reviewed-by: Julian Calaby <julian.calaby@gmail.com> Thanks, 1 patch applied to wireless-drivers-next.git: 8432ebd66205 hostap: Use memdup_user() to reuse code
diff --git a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c index 3e5fa78..a5656bc 100644 --- a/drivers/net/wireless/intersil/hostap/hostap_ioctl.c +++ b/drivers/net/wireless/intersil/hostap/hostap_ioctl.c @@ -3041,13 +3041,9 @@ static int prism2_ioctl_priv_download(local_info_t *local, struct iw_point *p) p->length > 1024 || !p->pointer) return -EINVAL; - param = kmalloc(p->length, GFP_KERNEL); - if (param == NULL) - return -ENOMEM; - - if (copy_from_user(param, p->pointer, p->length)) { - ret = -EFAULT; - goto out; + param = memdup_user(p->pointer, p->length); + if (IS_ERR(param)) { + return PTR_ERR(param); } if (p->length < sizeof(struct prism2_download_param) + @@ -3803,13 +3799,9 @@ static int prism2_ioctl_priv_hostapd(local_info_t *local, struct iw_point *p) p->length > PRISM2_HOSTAPD_MAX_BUF_SIZE || !p->pointer) return -EINVAL; - param = kmalloc(p->length, GFP_KERNEL); - if (param == NULL) - return -ENOMEM; - - if (copy_from_user(param, p->pointer, p->length)) { - ret = -EFAULT; - goto out; + param = memdup_user(p->pointer, p->length); + if (IS_ERR(param)) { + return PTR_ERR(param); } switch (param->cmd) {
Fix coccicheck warning which recommends to use memdup_user() instead of reimplementing its code. This patch fixes below coccicheck warnings: drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3044:9-16: WARNING opportunity for memdup_user drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3806:9-16: WARNING opportunity for memdup_user Signed-off-by: Rajan Vaja <rajan.vaja@gmail.com> --- drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-)