diff mbox

rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing

Message ID 1484319307-10821-1-git-send-email-sgruszka@redhat.com (mailing list archive)
State Accepted
Commit feecb0cb466ba458f59640b4d59ecef1cd956b1f
Delegated to: Kalle Valo
Headers show

Commit Message

Stanislaw Gruszka Jan. 13, 2017, 2:55 p.m. UTC
Since rt2800pci update beacon settings asynchronously from
tbtt tasklet, without beacon_skb_mutex protection, number of
currently active beacons entries can be different than
number pointed by rt2x00dev->intf_beaconing. Remove warning
about that inconsistency.

Reported-by: evaxige@qq.com
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Kalle Valo Jan. 19, 2017, 12:48 p.m. UTC | #1
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> Since rt2800pci update beacon settings asynchronously from
> tbtt tasklet, without beacon_skb_mutex protection, number of
> currently active beacons entries can be different than
> number pointed by rt2x00dev->intf_beaconing. Remove warning
> about that inconsistency.
> 
> Reported-by: evaxige@qq.com
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Patch applied to wireless-drivers-next.git, thanks.

feecb0cb466b rt2800: remove warning on bcn_num != rt2x00dev->intf_beaconing
diff mbox

Patch

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 4fb79e0..1abe38f 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -967,8 +967,6 @@  static void rt2800_update_beacons_setup(struct rt2x00_dev *rt2x00dev)
 		bcn_num++;
 	}
 
-	WARN_ON_ONCE(bcn_num != rt2x00dev->intf_beaconing);
-
 	rt2800_register_write(rt2x00dev, BCN_OFFSET0, (u32) reg);
 	rt2800_register_write(rt2x00dev, BCN_OFFSET1, (u32) (reg >> 32));