| Message ID | 1487104037-24941-2-git-send-email-rmanohar@qca.qualcomm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Johannes Berg |
| Headers | show |
On Tue, 2017-02-14 at 12:27 -0800, Rajkumar Manoharan wrote: > Mesh failure average never be more than 100. Only in case of > fixed path, average will be more than threshold limit (95%). > With recent EWMA changes it may go upto 99 as it is scaled to > 100. It make sense to return maximum metric when average is > greater than threshold limit. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com> > --- > net/mac80211/mesh_hwmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c > index d07ee3ca07ee..02c30a21eb66 100644 > --- a/net/mac80211/mesh_hwmp.c > +++ b/net/mac80211/mesh_hwmp.c > @@ -339,7 +339,7 @@ static u32 airtime_link_metric_get(struct > ieee80211_local *local, > if (rate) { > err = 0; > } else { > - if (fail_avg >= 100) > + if (fail_avg >= 95) > return MAX_METRIC; Why is this >= and the other place is >? Also, I think it'd be good to introduce a #define for this value now, perhaps something like "LINK_FAIL_THRESH". johannes
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c index d07ee3ca07ee..02c30a21eb66 100644 --- a/net/mac80211/mesh_hwmp.c +++ b/net/mac80211/mesh_hwmp.c @@ -339,7 +339,7 @@ static u32 airtime_link_metric_get(struct ieee80211_local *local, if (rate) { err = 0; } else { - if (fail_avg >= 100) + if (fail_avg >= 95) return MAX_METRIC; sta_set_rate_info_tx(sta, &sta->tx_stats.last_rate, &rinfo);
Mesh failure average never be more than 100. Only in case of fixed path, average will be more than threshold limit (95%). With recent EWMA changes it may go upto 99 as it is scaled to 100. It make sense to return maximum metric when average is greater than threshold limit. Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com> --- net/mac80211/mesh_hwmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)