[1/2] mac80211: Update the driver with beacon info constantly

Commit Message

Doru Feb. 15, 2017, 7:01 p.m. UTC

From: Doru Gucea <[e-mail]>

Once the mac80211 layer receives a beacon, it should send a notification
to the driver. This will allow finer timining control in case of drivers
that need a correct estimation for the arrival time of a beacon.

Signed-off-by: Doru Gucea <[e-mail]>
---
 net/mac80211/mlme.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

kernel test robot Feb. 15, 2017, 8:41 p.m. UTC | #1

Hi Doru,

[auto build test ERROR on mac80211-next/master]
[also build test ERROR on v4.10-rc8 next-20170215]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Doru/mac80211-Update-the-driver-with-beacon-info-constantly/20170216-034614
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: x86_64-lkp (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon':
>> net/mac80211/mlme.c:3555:35: error: 'sata' undeclared (first use in this function)
     ieee80211_bss_info_change_notify(sata, changed);
                                      ^~~~
   net/mac80211/mlme.c:3555:35: note: each undeclared identifier is reported only once for each function it appears in

vim +/sata +3555 net/mac80211/mlme.c

  3549		}
  3550	
  3551		/* trigger hardware timers adjustment
  3552		 * this needs to be done before beacon filtering
  3553		*/
  3554		changed |= BSS_CHANGED_BEACON_INFO;
> 3555		ieee80211_bss_info_change_notify(sata, changed);
  3556	
  3557		if (ncrc == ifmgd->beacon_crc && ifmgd->beacon_crc_valid)
  3558			return;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Patch

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index cd7e55e..0b8eed5 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -3536,6 +3536,12 @@  static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
 			sdata->vif.bss_conf.sync_dtim_count = 0;
 	}
 
+	/* trigger hardware timers adjustment
+	 * this needs to be done before beacon filtering
+	*/
+	changed |= BSS_CHANGED_BEACON_INFO;
+	ieee80211_bss_info_change_notify(sata, changed);
+
 	if (ncrc == ifmgd->beacon_crc && ifmgd->beacon_crc_valid)
 		return;
 	ifmgd->beacon_crc = ncrc;