diff mbox

Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

Message ID 1488471247-11820-1-git-send-email-geo.emmnl@gmail.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Georgios Emmanouil March 2, 2017, 4:14 p.m. UTC
Modified the 'if-else' statement to make it more readable.

Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
 drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

--
2.1.4

Comments

Julian Calaby March 4, 2017, 10:47 p.m. UTC | #1
Hi All,

On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>

Again, I'm dubious if this is needed or helpful, but

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

> ---
>  drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
diff mbox

Patch

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..d82f0ff 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -867,15 +867,10 @@  static int wilc_mac_open(struct net_device *ndev)
 							 wilc_get_vif_idx(vif),
 							 wl->open_ifcs);
 			} else {
-				if (memcmp(wl->vif[i ^ 1]->bssid,
-					   wl->vif[i ^ 1]->src_addr, 6))
-					wilc_set_wfi_drv_handler(vif,
-							 wilc_get_vif_idx(vif),
-							 0);
+				if (memcmp(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 1]->src_addr, 6))
+					wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 0);
 				else
-					wilc_set_wfi_drv_handler(vif,
-							 wilc_get_vif_idx(vif),
-							 1);
+					wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 1);
 			}
 			wilc_set_operation_mode(vif, vif->iftype);