diff mbox

[v2,07/20] rsi: correct the logic of deriving queue number

Message ID 1497624881-2315-8-git-send-email-amit.karwar@redpinesignals.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

Amitkumar Karwar June 16, 2017, 2:54 p.m. UTC 
Maximum valid queue number is 0x5. So anding with 0x7 should be
ok here.

Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
---
 drivers/net/wireless/rsi/rsi_91x_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo June 28, 2017, 6:32 p.m. UTC | #1 
Amitkumar Karwar <amitkarwar@gmail.com> writes:

> Maximum valid queue number is 0x5. So anding with 0x7 should be
> ok here.
>
> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>

The separate From header is missing which you had in v1.
Amitkumar Karwar July 6, 2017, 2:52 p.m. UTC | #2 
On Thu, Jun 29, 2017 at 12:02 AM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Amitkumar Karwar <amitkarwar@gmail.com> writes:
>
>> Maximum valid queue number is 0x5. So anding with 0x7 should be
>> ok here.
>>
>> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
>
> The separate From header is missing which you had in v1.

Thanks. This is corrected in v3.

Regards,
Amitkumar
diff mbox

Patch

diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index 25f6195..dc0a0b2 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -381,7 +381,7 @@  static int rsi_usb_host_intf_write_pkt(struct rsi_hw *adapter,
 				       u8 *pkt,
 				       u32 len)
 {
-	u32 queueno = ((pkt[1] >> 4) & 0xf);
+	u32 queueno = ((pkt[1] >> 4) & 0x7);
 	u8 endpoint;
 
 	endpoint = ((queueno == RSI_WIFI_MGMT_Q) ? MGMT_EP : DATA_EP);