diff mbox

rsi: fix uninitialized descriptor pointer issue

Message ID 1501770400-6659-1-git-send-email-amitkarwar@gmail.com (mailing list archive)
State Accepted
Commit 6345016d4bea6a82300c209d99e7f593800e3b4e
Delegated to: Kalle Valo
Headers show

Commit Message

Amitkumar Karwar Aug. 3, 2017, 2:26 p.m. UTC 
From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>

This patch fixes the uninitialized descriptor pointer
issue in function rsi_send_internal_mgmt_frame().
Descriptor should point to start of the skb data.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
---
 drivers/net/wireless/rsi/rsi_91x_mgmt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Aug. 8, 2017, 11:45 a.m. UTC | #1 
Amitkumar Karwar <amitkarwar@gmail.com> wrote:

> From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> 
> This patch fixes the uninitialized descriptor pointer
> issue in function rsi_send_internal_mgmt_frame().
> Descriptor should point to start of the skb data.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>

Patch applied to wireless-drivers-next.git, thanks.

6345016d4bea rsi: fix uninitialized descriptor pointer issue
diff mbox

Patch

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index c6e8a20..ba8a68f 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -275,6 +275,7 @@  static int rsi_send_internal_mgmt_frame(struct rsi_common *common,
 		rsi_dbg(ERR_ZONE, "%s: Unable to allocate skb\n", __func__);
 		return -ENOMEM;
 	}
+	desc = (struct rsi_cmd_desc *)skb->data;
 	desc->desc_dword0.len_qno |= cpu_to_le16(DESC_IMMEDIATE_WAKEUP);
 	skb->priority = MGMT_SOFT_Q;
 	tx_params = (struct skb_info *)&IEEE80211_SKB_CB(skb)->driver_data;