| Message ID | 1502295823-20824-2-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c5c60b2d577e88c50beae6ecf469b7a78643be4f |
| Delegated to: | Kalle Valo |
| Headers | show |
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by <linux/usb.h> work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> 17 patches applied to wireless-drivers-next.git, thanks. c5c60b2d577e ar5523: constify usb_device_id 76f6a5c80a4b carl9170: constify usb_device_id 22796d149229 at76c50x: constify usb_device_id c4291319b6fe orinoco: constify usb_device_id 54c9f21605d8 p54: constify usb_device_id 3673c417f509 libertas: constify usb_device_id 8a3132fa6bbb libertas_tf: constify usb_device_id 7516dbd470e3 mwifiex: constify usb_device_id e2717b312750 mt7601u: constify usb_device_id 88ee79a1a11c rt2500usb: constify usb_device_id c7bb7d79cf4f rt2800usb: constify usb_device_id 543e4f87508b rt73usb: constify usb_device_id e0b081b20523 rtl8187: constify usb_device_id 5033d70de169 rtl8xxxu: constify usb_device_id 3a55a4afd187 rtl8192cu: constify usb_device_id b924ffd7a4cd zd1201: constify usb_device_id ecf23a788e13 zd1211rw: constify usb_device_id
diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c index 106d6f8..68f0463 100644 --- a/drivers/net/wireless/ath/ar5523/ar5523.c +++ b/drivers/net/wireless/ath/ar5523/ar5523.c @@ -1749,7 +1749,7 @@ static void ar5523_disconnect(struct usb_interface *intf) { USB_DEVICE((vendor), (device) + 1), \ .driver_info = AR5523_FLAG_ABG|AR5523_FLAG_PRE_FIRMWARE } -static struct usb_device_id ar5523_id_table[] = { +static const struct usb_device_id ar5523_id_table[] = { AR5523_DEVICE_UG(0x168c, 0x0001), /* Atheros / AR5523 */ AR5523_DEVICE_UG(0x0cf3, 0x0001), /* Atheros2 / AR5523_1 */ AR5523_DEVICE_UG(0x0cf3, 0x0003), /* Atheros2 / AR5523_2 */
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by <linux/usb.h> work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: Re-submitting wireless separately. drivers/net/wireless/ath/ar5523/ar5523.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)