| Message ID | 1507467969-24016-1-git-send-email-baijiaju1990@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c0d5adc35c0b010120391117cb07be6623cf8940 |
| Delegated to: | Kalle Valo |
| Headers | show |
On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote: > No rcu_read_lock is called, but rcu_read_unlock is still called. > Thus rcu_read_unlock should be removed. > Thanks, not sure how I could miss that one. Kalle can you please include this in a v4.14-rc pull request? : Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration") > Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/net/wireless/ath/wcn36xx/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c > index 35bd50b..b83f01d 100644 > --- a/drivers/net/wireless/ath/wcn36xx/main.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw, > if (!sta) { > wcn36xx_err("sta %pM is not found\n", > bss_conf->bssid); > - rcu_read_unlock(); > goto out; > } > sta_priv = wcn36xx_sta_to_priv(sta); > -- > 1.7.9.5 > > > > _______________________________________________ > wcn36xx mailing list > wcn36xx@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/wcn36xx
Bjorn Andersson <bjorn.andersson@linaro.org> writes: > On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote: > >> No rcu_read_lock is called, but rcu_read_unlock is still called. >> Thus rcu_read_unlock should be removed. >> > > Thanks, not sure how I could miss that one. Kalle can you please include > this in a v4.14-rc pull request? > > > : > > Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration") > >> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> > > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Ok, I'll queue this to 4.14.
Jia-Ju Bai <baijiaju1990@163.com> wrote: > No rcu_read_lock is called, but rcu_read_unlock is still called. > Thus rcu_read_unlock should be removed. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Patch applied to ath-current branch of ath.git, thanks. c0d5adc35c0b wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 35bd50b..b83f01d 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw, if (!sta) { wcn36xx_err("sta %pM is not found\n", bss_conf->bssid); - rcu_read_unlock(); goto out; } sta_priv = wcn36xx_sta_to_priv(sta);
No rcu_read_lock is called, but rcu_read_unlock is still called. Thus rcu_read_unlock should be removed. Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> --- drivers/net/wireless/ath/wcn36xx/main.c | 1 - 1 file changed, 1 deletion(-)