| Message ID | 1515582771-28408-6-git-send-email-ajay.kathat@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Wed, Jan 10, 2018 at 04:42:47PM +0530, Ajay Singh wrote: > This patch removes following N_OPERATING_MODE_T,N_OBSS_DETECTION_T, > N_PROTECTION_TYPE_T,N_SMPS_MODE_T,TX_ABORT_OPTION_T, typedef enum. > Now, these enums are used as anonymous-enums for constants. > > checkpatch.pl warning to not add new typedef is fixes with this patch. > > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> > --- > drivers/staging/wilc1000/wilc_wlan_if.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) This is the same subject line as the previous patch in the series, yet they are doing different things. Please take this series and work on the subject lines to make them a bit more unique and different from each other, and resend. thanks, greg k-h
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wilc_wlan_if.h index eec8760..cf4a44d 100644 --- a/drivers/staging/wilc1000/wilc_wlan_if.h +++ b/drivers/staging/wilc1000/wilc_wlan_if.h @@ -226,40 +226,40 @@ enum { G_RTS_CTS_PROT, }; -typedef enum { +enum { HT_MIXED_MODE = 1, HT_ONLY_20MHZ_MODE, HT_ONLY_20_40MHZ_MODE, -} N_OPERATING_MODE_T; +}; -typedef enum { +enum { NO_DETECT = 0, DETECT_ONLY = 1, DETECT_PROTECT = 2, DETECT_PROTECT_REPORT = 3, -} N_OBSS_DETECTION_T; +}; -typedef enum { +enum { RTS_CTS_NONHT_PROT = 0, /* RTS-CTS at non-HT rate */ FIRST_FRAME_NONHT_PROT, /* First frame at non-HT rate */ LSIG_TXOP_PROT, /* LSIG TXOP Protection */ FIRST_FRAME_MIXED_PROT, /* First frame at Mixed format */ -} N_PROTECTION_TYPE_T; +}; -typedef enum { +enum { STATIC_MODE = 1, DYNAMIC_MODE = 2, MIMO_MODE = 3, /* power save disable */ -} N_SMPS_MODE_T; +}; -typedef enum { +enum { DISABLE_SELF_CTS, ENABLE_SELF_CTS, DISABLE_TX_ABORT, ENABLE_TX_ABORT, HW_TRIGGER_ABORT, SW_TRIGGER_ABORT, -} TX_ABORT_OPTION_T; +}; enum wid_type { WID_CHAR = 0,
This patch removes following N_OPERATING_MODE_T,N_OBSS_DETECTION_T, N_PROTECTION_TYPE_T,N_SMPS_MODE_T,TX_ABORT_OPTION_T, typedef enum. Now, these enums are used as anonymous-enums for constants. checkpatch.pl warning to not add new typedef is fixes with this patch. Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> --- drivers/staging/wilc1000/wilc_wlan_if.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)