| Message ID | 1519662722-15761-9-git-send-email-ajay.kathat@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
The first 5 patches are good, but the last 3 are not OK. Normally "tmp" is used as an iterator pointer or something along those lines. For example, here is a good use of "tmp". tmp = left; left = right; right = tmp; In this example, you want to store a pointer temporarily, so what else are you going to call it besides "tmp"? The name "tmp" doesn't mean "I want a short name and I'm too lazy to think of one". regards, dan carpenter
Hi Dan, On Tue, 27 Feb 2018 12:41:40 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote: > The first 5 patches are good, but the last 3 are not OK. Thanks for your review comments. I will resubmit the patch series by only including first 5 patches. I will recheck the last 3 patches and submit them separately. > > Normally "tmp" is used as an iterator pointer or something along those > lines. For example, here is a good use of "tmp". > > tmp = left; > left = right; > right = tmp; > > In this example, you want to store a pointer temporarily, so what else > are you going to call it besides "tmp"? The name "tmp" doesn't mean > "I want a short name and I'm too lazy to think of one". > Sure, I will take care of this point in subsequent patches. Regards, Ajay
On Tue, Feb 27, 2018 at 06:53:40PM +0530, Ajay Singh wrote: > Hi Dan, > > On Tue, 27 Feb 2018 12:41:40 +0300 > Dan Carpenter <dan.carpenter@oracle.com> wrote: > > > The first 5 patches are good, but the last 3 are not OK. > > Thanks for your review comments. > I will resubmit the patch series by only including first 5 patches. I > will recheck the last 3 patches and submit them separately. > Greg can probably just apply the first 5 as-is. No need to resend. regards, dan carpenter
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index acf7591..971e61d2 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -1273,13 +1273,14 @@ int wilc_wlan_cfg_get(struct wilc_vif *vif, int start, u16 wid, int commit, wilc->cfg_frame_offset = offset; if (commit) { + unsigned long tmp = msecs_to_jiffies(CFG_PKTS_TIMEOUT); + wilc->cfg_frame_in_use = 1; if (wilc_wlan_cfg_commit(vif, WILC_CFG_QUERY, drv_handler)) ret_size = 0; - if (!wait_for_completion_timeout(&wilc->cfg_event, - msecs_to_jiffies(CFG_PKTS_TIMEOUT))) { + if (!wait_for_completion_timeout(&wilc->cfg_event, tmp)) { netdev_dbg(vif->ndev, "Get Timed Out\n"); ret_size = 0; }
Fix 'Alignment should match open parenthesis' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> --- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)