| Message ID | 1520485789-8550-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Thu, 8 Mar 2018 10:39:49 +0530 Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2: > Removed kfree() call for @dev. > > drivers/ssb/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c > index 65420a9..a7a062b 100644 > --- a/drivers/ssb/main.c > +++ b/drivers/ssb/main.c > @@ -521,8 +521,8 @@ static int ssb_devices_register(struct ssb_bus *bus) > ssb_err("Could not register %s\n", dev_name(dev)); > /* Set dev to NULL to not unregister > * dev on error unwinding. */ > + put_device(dev); > sdev->dev = NULL; > - kfree(devwrap); > goto error; > } > dev_idx++; Would you please put the put_device where the kfree was? So that the comment still matches. Thanks.
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..a7a062b 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -521,8 +521,8 @@ static int ssb_devices_register(struct ssb_bus *bus) ssb_err("Could not register %s\n", dev_name(dev)); /* Set dev to NULL to not unregister * dev on error unwinding. */ + put_device(dev); sdev->dev = NULL; - kfree(devwrap); goto error; } dev_idx++;
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: Removed kfree() call for @dev. drivers/ssb/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)