| Message ID | 1525682614-3824-29-git-send-email-ajay.kathat@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On 07.05.2018 11:43, Ajay Singh wrote: > Added comments for mutex and spinlock_t to avoid checkpatch.pl script. > > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> > --- > drivers/staging/wilc1000/host_interface.h | 2 +- > drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h > index 7a26f34..5e00dde 100644 > --- a/drivers/staging/wilc1000/host_interface.h > +++ b/drivers/staging/wilc1000/host_interface.h > @@ -271,7 +271,7 @@ struct host_if_drv { > > u8 assoc_bssid[ETH_ALEN]; > struct cfg_param_attr cfg_values; > - > +/*lock to protect concurrent setting of cfg params*/ > struct mutex cfg_values_lock; > struct completion comp_test_key_block; > struct completion comp_test_disconn_block; > diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/staging/wilc1000/wilc_wfi_netdevice.h > index 607dae0..e517768 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h > +++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h > @@ -131,10 +131,11 @@ struct wilc { > u8 vif_num; > struct wilc_vif *vif[NUM_CONCURRENT_IFC]; > u8 open_ifcs; > - > +/*protect head of transmit queue*/ Add an extra tag to align it with the rest of the structure's members. > struct mutex txq_add_to_head_cs; > +/*protect txq_entry_t transmit queue*/ Ditto > spinlock_t txq_spinlock; > - > +/*protect rxq_entry_t receiver queue*/ Ditto > struct mutex rxq_cs; > struct mutex hif_cs; > >
diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h index 7a26f34..5e00dde 100644 --- a/drivers/staging/wilc1000/host_interface.h +++ b/drivers/staging/wilc1000/host_interface.h @@ -271,7 +271,7 @@ struct host_if_drv { u8 assoc_bssid[ETH_ALEN]; struct cfg_param_attr cfg_values; - +/*lock to protect concurrent setting of cfg params*/ struct mutex cfg_values_lock; struct completion comp_test_key_block; struct completion comp_test_disconn_block; diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h b/drivers/staging/wilc1000/wilc_wfi_netdevice.h index 607dae0..e517768 100644 --- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h +++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h @@ -131,10 +131,11 @@ struct wilc { u8 vif_num; struct wilc_vif *vif[NUM_CONCURRENT_IFC]; u8 open_ifcs; - +/*protect head of transmit queue*/ struct mutex txq_add_to_head_cs; +/*protect txq_entry_t transmit queue*/ spinlock_t txq_spinlock; - +/*protect rxq_entry_t receiver queue*/ struct mutex rxq_cs; struct mutex hif_cs;
Added comments for mutex and spinlock_t to avoid checkpatch.pl script. Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> --- drivers/staging/wilc1000/host_interface.h | 2 +- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-)