diff mbox

mwifiex: increase TX threashold to avoid TX timeout during ED MAC test

Message ID 1525718458-5299-1-git-send-email-gbhat@marvell.com (mailing list archive)
State Accepted
Commit 4f9fb990013c03c5d56266fb4c439816cd84e1a6
Delegated to: Kalle Valo
Headers show

Commit Message

Ganapathi Bhat May 7, 2018, 6:40 p.m. UTC 
While carrying energy detection(ED) tests, the chip will stop
transmission upon detecting an energy in the connected channel.
As a feedback, driver will stop dequeuing TX packets and due to
which wmm_tx_pending keep incremeting. Once wmm_tx_pending
reaches 100, driver calls netif_tx_stop_queue(). If TX ques is
not restarted within 5(watchdog_timeo) seconds, it will result in
TX timeout.

The ED test is carried out for one minute and the current
threshold of 100 is easily overcome by the traffic, cuasing TX
timeouts. To fix this increase the threshold to 400.

Signed-off-by: Cathy Luo <cluo@marvell.com>
Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
---
 drivers/net/wireless/marvell/mwifiex/main.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo May 9, 2018, 10:26 a.m. UTC | #1 
Ganapathi Bhat <gbhat@marvell.com> wrote:

> While carrying energy detection(ED) tests, the chip will stop
> transmission upon detecting an energy in the connected channel.
> As a feedback, driver will stop dequeuing TX packets and due to
> which wmm_tx_pending keep incremeting. Once wmm_tx_pending
> reaches 100, driver calls netif_tx_stop_queue(). If TX ques is
> not restarted within 5(watchdog_timeo) seconds, it will result in
> TX timeout.
> 
> The ED test is carried out for one minute and the current
> threshold of 100 is easily overcome by the traffic, cuasing TX
> timeouts. To fix this increase the threshold to 400.
> 
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>

Patch applied to wireless-drivers-next.git, thanks.

4f9fb990013c mwifiex: increase TX threashold to avoid TX timeout during ED MAC test
diff mbox

Patch

diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
index b2a94b8..c5478c8 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.h
+++ b/drivers/net/wireless/marvell/mwifiex/main.h
@@ -84,8 +84,8 @@  enum {
 #define MWIFIEX_TIMER_10S			10000
 #define MWIFIEX_TIMER_1S			1000
 
-#define MAX_TX_PENDING      100
-#define LOW_TX_PENDING      80
+#define MAX_TX_PENDING      400
+#define LOW_TX_PENDING      380
 
 #define HIGH_RX_PENDING     50
 #define LOW_RX_PENDING      20