| Message ID | 1530771142-4118-12-git-send-email-sgruszka@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi Stanislaw,
I love your patch! Yet something to improve:
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.18-rc3 next-20180704]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Stanislaw-Gruszka/Add-mt76x0-driver/20180705-150550
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mt76x0/phy.c: In function 'mt76x0_phy_set_channel':
>> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:619:6: warning: 'bw' may be used uninitialized in this function [-Wmaybe-uninitialized]
int bw;
^~
>> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:350:6: warning: 'rf_band' may be used uninitialized in this function [-Wmaybe-uninitialized]
u16 rf_band;
^~~~~~~
--
>> make[7]: *** No rule to make target 'drivers/net/wireless/mediatek/mt76/mt76x0/main.o', needed by 'drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.o'.
make[7]: Target '__build' not remade because of errors.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Jul 05, Stanislaw Gruszka wrote: > Add Kconfig and Makefiles for mt76x0 driver. Now the driver > can be build. > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> > --- > drivers/net/wireless/mediatek/mt76/Kconfig | 7 +++++++ > drivers/net/wireless/mediatek/mt76/Makefile | 1 + > drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++ > 3 files changed, 15 insertions(+) > create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile > > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig > index fc05d79c80d0..84854736809a 100644 > --- a/drivers/net/wireless/mediatek/mt76/Kconfig > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > @@ -1,6 +1,13 @@ > config MT76_CORE > tristate > > +config MT76x0U > + tristate "MediaTek MT76x0U (USB) support" > + depends on MAC80211 > + depends on USB > + help > + This adds support for MT7610U-based wireless USB dongles. > + > config MT76x2E > tristate "MediaTek MT76x2E (PCIe) support" > select MT76_CORE > diff --git a/drivers/net/wireless/mediatek/mt76/Makefile b/drivers/net/wireless/mediatek/mt76/Makefile > index a0156bc01dea..08f93127e9e7 100644 > --- a/drivers/net/wireless/mediatek/mt76/Makefile > +++ b/drivers/net/wireless/mediatek/mt76/Makefile > @@ -1,4 +1,5 @@ > obj-$(CONFIG_MT76_CORE) += mt76.o > +obj-$(CONFIG_MT76x0U) += mt76x0/ > obj-$(CONFIG_MT76x2E) += mt76x2e.o > > mt76-y := \ > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile > new file mode 100644 > index 000000000000..7843908261ba > --- /dev/null > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile > @@ -0,0 +1,7 @@ > +obj-$(CONFIG_MT76x0U) += mt76x0.o > + > +mt76x0-objs = \ > + usb.o init.o main.o mcu.o trace.o dma.o eeprom.o phy.o \ There is no main.c source file, is it a leftover from previous implementation? Moreover compiling the driver (and fixing conflicts with mt76x2u) I have: ERROR: "mt76x0_ops" [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.ko] undefined! Regards, Lorenzo > + mac.o util.o debugfs.o tx.o core.o > +# ccflags-y := -DDEBUG > +CFLAGS_trace.o := -I$(src) > -- > 1.9.3 >
On Thu, Jul 05, 2018 at 04:50:19PM +0200, Lorenzo Bianconi wrote: > On Jul 05, Stanislaw Gruszka wrote: > > +obj-$(CONFIG_MT76x0U) += mt76x0.o > > + > > +mt76x0-objs = \ > > + usb.o init.o main.o mcu.o trace.o dma.o eeprom.o phy.o \ > > There is no main.c source file, is it a leftover from previous implementation? > Moreover compiling the driver (and fixing conflicts with mt76x2u) I have: > > ERROR: "mt76x0_ops" [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.ko] undefined! I somehow missed the patch adding main.c . Stanislaw
diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig index fc05d79c80d0..84854736809a 100644 --- a/drivers/net/wireless/mediatek/mt76/Kconfig +++ b/drivers/net/wireless/mediatek/mt76/Kconfig @@ -1,6 +1,13 @@ config MT76_CORE tristate +config MT76x0U + tristate "MediaTek MT76x0U (USB) support" + depends on MAC80211 + depends on USB + help + This adds support for MT7610U-based wireless USB dongles. + config MT76x2E tristate "MediaTek MT76x2E (PCIe) support" select MT76_CORE diff --git a/drivers/net/wireless/mediatek/mt76/Makefile b/drivers/net/wireless/mediatek/mt76/Makefile index a0156bc01dea..08f93127e9e7 100644 --- a/drivers/net/wireless/mediatek/mt76/Makefile +++ b/drivers/net/wireless/mediatek/mt76/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_MT76_CORE) += mt76.o +obj-$(CONFIG_MT76x0U) += mt76x0/ obj-$(CONFIG_MT76x2E) += mt76x2e.o mt76-y := \ diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile new file mode 100644 index 000000000000..7843908261ba --- /dev/null +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile @@ -0,0 +1,7 @@ +obj-$(CONFIG_MT76x0U) += mt76x0.o + +mt76x0-objs = \ + usb.o init.o main.o mcu.o trace.o dma.o eeprom.o phy.o \ + mac.o util.o debugfs.o tx.o core.o +# ccflags-y := -DDEBUG +CFLAGS_trace.o := -I$(src)
Add Kconfig and Makefiles for mt76x0 driver. Now the driver can be build. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> --- drivers/net/wireless/mediatek/mt76/Kconfig | 7 +++++++ drivers/net/wireless/mediatek/mt76/Makefile | 1 + drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++ 3 files changed, 15 insertions(+) create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile