diff mbox series

mt76x0: correct type for eeprom gain value

Message ID 1533631389-417-1-git-send-email-sgruszka@redhat.com (mailing list archive)
State Accepted
Commit 5dc5bf2899a505085492b1273d34d4a51c41e093
Delegated to: Kalle Valo
Headers show
Series mt76x0: correct type for eeprom gain value | expand

Commit Message

Stanislaw Gruszka Aug. 7, 2018, 8:43 a.m. UTC
Change type to u8 to allow sanity check agaist 0xff;

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e87b5039511a ("mt76x0: eeprom files")
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Aug. 9, 2018, 3:07 p.m. UTC | #1
Stanislaw Gruszka <sgruszka@redhat.com> wrote:

> Change type to u8 to allow sanity check agaist 0xff;
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: e87b5039511a ("mt76x0: eeprom files")
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Patch applied to wireless-drivers-next.git, thanks.

5dc5bf2899a5 mt76x0: correct type for eeprom gain value
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
index 1ecd018f12b8..9ea5f5ebd3be 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/eeprom.c
@@ -241,7 +241,7 @@ 
 static void
 mt76x0_set_lna_gain(struct mt76x0_dev *dev, u8 *eeprom)
 {
-	s8 gain;
+	u8 gain;
 
 	dev->ee->lna_gain_2ghz = eeprom[MT_EE_LNA_GAIN_2GHZ];
 	dev->ee->lna_gain_5ghz[0] = eeprom[MT_EE_LNA_GAIN_5GHZ_0];