diff mbox series

[4/5] staging: wilc1000: change permission to 0600 in debugfs_create_file() call

Message ID 1534049265-5600-5-git-send-email-ajay.kathat@microchip.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show
Series staging: wilc1000: compilation error fixes & cleanup changes | expand

Commit Message

Ajay Singh Aug. 12, 2018, 4:47 a.m. UTC 
Cleanup patch to use more restrictive access permission for debugfs
file.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Aug. 12, 2018, 11:36 a.m. UTC | #1 
On Sun, Aug 12, 2018 at 10:17:44AM +0530, Ajay Singh wrote:
> Cleanup patch to use more restrictive access permission for debugfs
> file.

Why?  What is the harm in writing to a value that is never used?  :)

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index c9bc325..15e797b 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -65,7 +65,7 @@  ssize_t wilc_debug_level_write(struct file *filp, const char __user *buf,
 int wilc_debugfs_init(const struct file_operations *fops)
 {
 	wilc_dir = debugfs_create_dir("wilc_wifi", NULL);
-	debugfs_create_file("wilc_debug_level", 0666, wilc_dir, NULL, fops);
+	debugfs_create_file("wilc_debug_level", 0600, wilc_dir, NULL, fops);
 
 	return 0;
 }