| Message ID | 1540283282-9772-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen' | expand |
On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > It is safe to remove the unused variable. Meanwhile, radio B radio should be > removed as well. because it will no longer be referenced. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Thank you
On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its value. > It is safe to remove the unused variable. Meanwhile, radio B radio should be > removed as well. because it will no longer be referenced. The patch subject is a bit off and too generic here. This is specific to rtl8723ae and not rtlwifi so it is probably better for the subject to be something like: [PATCH] rtl8723ae: Remove set but not used variables and #defines > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 --
On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote: > On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > > It is safe to remove the unused variable. Meanwhile, radio B radio should be > > removed as well. because it will no longer be referenced. > > The patch subject is a bit off and too generic here. > > This is specific to rtl8723ae and not rtlwifi so it is > probably better for the subject to be something like: > > [PATCH] rtl8723ae: Remove set but not used variables and #defines I'd like 'rtlwifi: rtl8723ae: ' as subject prefix. > > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > > --- > > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- > > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- > > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 -- > > > ------Please consider the environment before printing this e-mail.
On 2018/10/24 8:52, Pkshih wrote: > On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote: >> On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: >>> radiob_array_table' and 'radiob_arraylen' are not used after setting its >> value. >>> It is safe to remove the unused variable. Meanwhile, radio B radio should be >>> removed as well. because it will no longer be referenced. >> The patch subject is a bit off and too generic here. >> >> This is specific to rtl8723ae and not rtlwifi so it is >> probably better for the subject to be something like: >> >> [PATCH] rtl8723ae: Remove set but not used variables and #defines > I'd like 'rtlwifi: rtl8723ae: ' as subject prefix. Thanks for your suggestion. Will change the subject and resend. [PATCH] rtlwifi: rtl8723ae: Remove set but not used variables and #defines Thanks, zhong jiang >>> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >>> --- >>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- >>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- >>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 -- >> >> ------Please consider the environment before printing this e-mail.
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c index 5cf29f5..3f33278 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw, int i; bool rtstatus = true; u32 *radioa_array_table; - u32 *radiob_array_table; - u16 radioa_arraylen, radiob_arraylen; + u16 radioa_arraylen; radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH; radioa_array_table = RTL8723E_RADIOA_1TARRAY; - radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH; - radiob_array_table = RTL8723E_RADIOB_1TARRAY; rtstatus = true; diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c index 61e8604..1bbee0b 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c @@ -475,10 +475,6 @@ 0x000, 0x00030159, }; -u32 RTL8723E_RADIOB_1TARRAY[RTL8723E_RADIOB_1TARRAYLENGTH] = { - 0x0, -}; - u32 RTL8723EMAC_ARRAY[RTL8723E_MACARRAYLENGTH] = { 0x420, 0x00000080, 0x423, 0x00000000, diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h index 57a548c..a044f3c 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h @@ -36,8 +36,6 @@ extern u32 RTL8723EPHY_REG_ARRAY_PG[RTL8723E_PHY_REG_ARRAY_PGLENGTH]; #define RTL8723ERADIOA_1TARRAYLENGTH 282 extern u32 RTL8723E_RADIOA_1TARRAY[RTL8723ERADIOA_1TARRAYLENGTH]; -#define RTL8723E_RADIOB_1TARRAYLENGTH 1 -extern u32 RTL8723E_RADIOB_1TARRAY[RTL8723E_RADIOB_1TARRAYLENGTH]; #define RTL8723E_MACARRAYLENGTH 172 extern u32 RTL8723EMAC_ARRAY[RTL8723E_MACARRAYLENGTH]; #define RTL8723E_AGCTAB_1TARRAYLENGTH 320
radiob_array_table' and 'radiob_arraylen' are not used after setting its value. It is safe to remove the unused variable. Meanwhile, radio B radio should be removed as well. because it will no longer be referenced. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 -- 3 files changed, 1 insertion(+), 10 deletions(-)