| Message ID | 1541417130-9898-1-git-send-email-zhangshaokun@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7d129adff3afbd3a449bc3593f2064ac546d58d3 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information | expand |
On Mon, 2018-11-05 at 19:25 +0800, Shaokun Zhang wrote: > RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x' > prefix, which is somewhat misleading. > > Fix it to print hexadecimal, as was intended. > > Cc: Ping-Ke Shih <pkshih@realtek.com> > Cc: Kalle Valo <kvalo@codeaurora.org> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c > index 85cedd0..75bfa9d 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c > @@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw) > rtl_read_byte(rtlpriv, FW_MAC1_READY)); > } > RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG, > - "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n", > + "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n", > rtl_read_dword(rtlpriv, REG_MCUFWDL)); > return -1; > } Acked-by: Ping-Ke Shih <pkshih@realtek.com> Thanks for your fix.
Shaokun Zhang <zhangshaokun@hisilicon.com> wrote: > RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x' > prefix, which is somewhat misleading. > > Fix it to print hexadecimal, as was intended. > > Cc: Ping-Ke Shih <pkshih@realtek.com> > Cc: Kalle Valo <kvalo@codeaurora.org> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-drivers-next.git, thanks. 7d129adff3af rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c index 85cedd0..75bfa9d 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c @@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw) rtl_read_byte(rtlpriv, FW_MAC1_READY)); } RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG, - "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n", + "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n", rtl_read_dword(rtlpriv, REG_MCUFWDL)); return -1; }
RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x' prefix, which is somewhat misleading. Fix it to print hexadecimal, as was intended. Cc: Ping-Ke Shih <pkshih@realtek.com> Cc: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)