| Message ID | 1553012645-28989-1-git-send-email-chongguiguzi@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0b2ff1ff64c88eeca2494f2b02cade39e9cd15b2 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | net:mwl8k:move spin_lock_bh to spin_lock in tasklet | expand |
Is it possible that this solves this long standing issue? : https://www.spinics.net/lists/linux-wireless/msg151171.html Bye Il giorno mar 19 mar 2019 alle ore 17:25 Jeff Xie <chongguiguzi@gmail.com> ha scritto: > > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> > --- > drivers/net/wireless/marvell/mwl8k.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c > index 8e4e9b6..21a86cc 100644 > --- a/drivers/net/wireless/marvell/mwl8k.c > +++ b/drivers/net/wireless/marvell/mwl8k.c > @@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data) > > limit = 32; > > - spin_lock_bh(&priv->tx_lock); > + spin_lock(&priv->tx_lock); > > for (i = 0; i < mwl8k_tx_queues(priv); i++) > limit -= mwl8k_txq_reclaim(hw, i, limit, 0); > @@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data) > priv->tx_wait = NULL; > } > > - spin_unlock_bh(&priv->tx_lock); > + spin_unlock(&priv->tx_lock); > > if (limit) { > writel(~MWL8K_A2H_INT_TX_DONE, > -- > 2.7.4 >
Jeff Xie <chongguiguzi@gmail.com> wrote: > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> Patch applied to wireless-drivers-next.git, thanks. 0b2ff1ff64c8 mwl8k: move spin_lock_bh to spin_lock in tasklet
diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c index 8e4e9b6..21a86cc 100644 --- a/drivers/net/wireless/marvell/mwl8k.c +++ b/drivers/net/wireless/marvell/mwl8k.c @@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data) limit = 32; - spin_lock_bh(&priv->tx_lock); + spin_lock(&priv->tx_lock); for (i = 0; i < mwl8k_tx_queues(priv); i++) limit -= mwl8k_txq_reclaim(hw, i, limit, 0); @@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data) priv->tx_wait = NULL; } - spin_unlock_bh(&priv->tx_lock); + spin_unlock(&priv->tx_lock); if (limit) { writel(~MWL8K_A2H_INT_TX_DONE,
It is unnecessary to call spin_lock_bh in a tasklet. Signed-off-by: Jeff Xie <chongguiguzi@gmail.com> --- drivers/net/wireless/marvell/mwl8k.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)