| Message ID | 1556879502-16211-7-git-send-email-yhchuang@realtek.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtw88: minor fixes from suggestions during review | expand |
<yhchuang@realtek.com> writes: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > The LPS represents Leisure Power Save. When enabled, firmware will be in > charge of turning radio off between beacons. Also firmware should turn > on the radio when beacon is coming, and the data queued should be > transmitted in TBTT period. > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > --- > drivers/net/wireless/realtek/rtw88/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtw88/main.c > b/drivers/net/wireless/realtek/rtw88/main.c > index f447361..6953013 100644 > --- a/drivers/net/wireless/realtek/rtw88/main.c > +++ b/drivers/net/wireless/realtek/rtw88/main.c > @@ -20,7 +20,7 @@ EXPORT_SYMBOL(rtw_debug_mask); > module_param_named(support_lps, rtw_fw_support_lps, bool, 0644); > module_param_named(debug_mask, rtw_debug_mask, uint, 0644); > > -MODULE_PARM_DESC(support_lps, "Set Y to enable LPS support"); > +MODULE_PARM_DESC(support_lps, "Set Y to enable Leisure Power Save > support, turn radio off between beacons"); I think it would help to add: ", to turn radio off between beacons"
> Subject: Re: [PATCH 6/6] rtw88: more descriptions about LPS > > <yhchuang@realtek.com> writes: > > > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > > > The LPS represents Leisure Power Save. When enabled, firmware will be in > > charge of turning radio off between beacons. Also firmware should turn > > on the radio when beacon is coming, and the data queued should be > > transmitted in TBTT period. > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> > > --- > > drivers/net/wireless/realtek/rtw88/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/realtek/rtw88/main.c > > b/drivers/net/wireless/realtek/rtw88/main.c > > index f447361..6953013 100644 > > --- a/drivers/net/wireless/realtek/rtw88/main.c > > +++ b/drivers/net/wireless/realtek/rtw88/main.c > > @@ -20,7 +20,7 @@ EXPORT_SYMBOL(rtw_debug_mask); > > module_param_named(support_lps, rtw_fw_support_lps, bool, 0644); > > module_param_named(debug_mask, rtw_debug_mask, uint, 0644); > > > > -MODULE_PARM_DESC(support_lps, "Set Y to enable LPS support"); > > +MODULE_PARM_DESC(support_lps, "Set Y to enable Leisure Power Save > > support, turn radio off between beacons"); > > I think it would help to add: > > ", to turn radio off between beacons" > Looks better, will include it in v2. Thanks. Yan-Hsuan
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index f447361..6953013 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -20,7 +20,7 @@ EXPORT_SYMBOL(rtw_debug_mask); module_param_named(support_lps, rtw_fw_support_lps, bool, 0644); module_param_named(debug_mask, rtw_debug_mask, uint, 0644); -MODULE_PARM_DESC(support_lps, "Set Y to enable LPS support"); +MODULE_PARM_DESC(support_lps, "Set Y to enable Leisure Power Save support, turn radio off between beacons"); MODULE_PARM_DESC(debug_mask, "Debugging mask"); static struct ieee80211_channel rtw_channeltable_2g[] = {