| Message ID | 1566316095-27507-2-git-send-email-kvalo@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: driver for Qualcomm IEEE 802.11ax devices | expand |
On Tue, Aug 20, 2019 at 06:47:27PM +0300, Kalle Valo wrote: Missing commit message and Sob (and on the other patches). > --- > .../bindings/net/wireless/qcom,ath11k.txt | 127 +++++++++++++++++++++ > 1 file changed, 127 insertions(+) Please use the DT schema format (YAML). See writing-schema.md. > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt > new file mode 100644 > index 000000000000..1824238b4b50 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt > @@ -0,0 +1,127 @@ > +* Qualcomm Technologies ath11k wireless devices > + > +Required properties: > +- compatible: Should be "qcom,ipq8074-wifi" > + > +AHB based ipq8074 uses most of the properties defined in this doc. > + > +Optional properties: > +- reg: Address and length of the register set for the device. > +- interrupts: List of interrupt lines. Must contain an entry > + for each entry in the interrupt-names property. Need to be explicit as to how many interrupts and what they are. > +- interrupt-names: Must include the entries for CE interrupt > + names ("ce0" to "ce11") and hw srng interrupt > + names. > +- qcom,rproc: DT entry of q6v5-wcss > + > +Example: > + > +wifi0: wifi@c000000 { > + compatible = "qcom,ipq8074-wifi"; > + reg = <0xc000000 0x2000000>; > + interrupts = <0 320 1>, > + <0 319 1>, > + <0 318 1>, > + <0 317 1>, > + <0 316 1>, > + <0 315 1>, > + <0 314 1>, > + <0 311 1>, > + <0 310 1>, > + <0 411 1>, > + <0 410 1>, > + <0 40 1>, > + <0 39 1>, > + <0 302 1>, > + <0 301 1>, > + <0 37 1>, > + <0 36 1>, > + <0 296 1>, > + <0 295 1>, > + <0 294 1>, > + <0 293 1>, > + <0 292 1>, > + <0 291 1>, > + <0 290 1>, > + <0 289 1>, > + <0 288 1>, > + <0 239 1>, > + <0 236 1>, > + <0 235 1>, > + <0 234 1>, > + <0 233 1>, > + <0 232 1>, > + <0 231 1>, > + <0 230 1>, > + <0 229 1>, > + <0 228 1>, > + <0 224 1>, > + <0 223 1>, > + <0 203 1>, > + <0 183 1>, > + <0 180 1>, > + <0 179 1>, > + <0 178 1>, > + <0 177 1>, > + <0 176 1>, > + <0 163 1>, > + <0 162 1>, > + <0 160 1>, > + <0 159 1>, > + <0 158 1>, > + <0 157 1>, > + <0 156 1>; > + interrupt-names = "misc-pulse1", > + "misc-latch", > + "sw-exception", > + "watchdog", > + "ce0", > + "ce1", > + "ce2", > + "ce3", > + "ce4", > + "ce5", > + "ce6", > + "ce7", > + "ce8", > + "ce9", > + "ce10", > + "ce11", > + "host2wbm-desc-feed", > + "host2reo-re-injection", > + "host2reo-command", > + "host2rxdma-monitor-ring3", > + "host2rxdma-monitor-ring2", > + "host2rxdma-monitor-ring1", > + "reo2ost-exception", > + "wbm2host-rx-release", > + "reo2host-status", > + "reo2host-destination-ring4", > + "reo2host-destination-ring3", > + "reo2host-destination-ring2", > + "reo2host-destination-ring1", > + "rxdma2host-monitor-destination-mac3", > + "rxdma2host-monitor-destination-mac2", > + "rxdma2host-monitor-destination-mac1", > + "ppdu-end-interrupts-mac3", > + "ppdu-end-interrupts-mac2", > + "ppdu-end-interrupts-mac1", > + "rxdma2host-monitor-status-ring-mac3", > + "rxdma2host-monitor-status-ring-mac2", > + "rxdma2host-monitor-status-ring-mac1", > + "host2rxdma-host-buf-ring-mac3", > + "host2rxdma-host-buf-ring-mac2", > + "host2rxdma-host-buf-ring-mac1", > + "rxdma2host-destination-ring-mac3", > + "rxdma2host-destination-ring-mac2", > + "rxdma2host-destination-ring-mac1", > + "host2tcl-input-ring4", > + "host2tcl-input-ring3", > + "host2tcl-input-ring2", > + "host2tcl-input-ring1", > + "wbm2host-tx-completions-ring3", > + "wbm2host-tx-completions-ring2", > + "wbm2host-tx-completions-ring1", > + "tcl2host-status-ring"; > + qcom,rproc = <&qcom_q6v5_wcss>; > +}; >
Rob Herring <robh@kernel.org> writes: > On Tue, Aug 20, 2019 at 06:47:27PM +0300, Kalle Valo wrote: > > Missing commit message and Sob (and on the other patches). My original plan was to commit all this in one commit and use the cover letter as my commit. But based on your comment I realised we should have three commits: 1. devicetree bindings doc 2. ath11k itself 3. add entry to MAINTAINERS file >> --- >> .../bindings/net/wireless/qcom,ath11k.txt | 127 +++++++++++++++++++++ >> 1 file changed, 127 insertions(+) > > Please use the DT schema format (YAML). See writing-schema.md. Oh, I didn't know about the new format. We'll use that. >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt >> @@ -0,0 +1,127 @@ >> +* Qualcomm Technologies ath11k wireless devices >> + >> +Required properties: >> +- compatible: Should be "qcom,ipq8074-wifi" >> + >> +AHB based ipq8074 uses most of the properties defined in this doc. >> + >> +Optional properties: >> +- reg: Address and length of the register set for the device. >> +- interrupts: List of interrupt lines. Must contain an entry >> + for each entry in the interrupt-names property. > > Need to be explicit as to how many interrupts and what they are. Ok, we'll add that.
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt new file mode 100644 index 000000000000..1824238b4b50 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.txt @@ -0,0 +1,127 @@ +* Qualcomm Technologies ath11k wireless devices + +Required properties: +- compatible: Should be "qcom,ipq8074-wifi" + +AHB based ipq8074 uses most of the properties defined in this doc. + +Optional properties: +- reg: Address and length of the register set for the device. +- interrupts: List of interrupt lines. Must contain an entry + for each entry in the interrupt-names property. +- interrupt-names: Must include the entries for CE interrupt + names ("ce0" to "ce11") and hw srng interrupt + names. +- qcom,rproc: DT entry of q6v5-wcss + +Example: + +wifi0: wifi@c000000 { + compatible = "qcom,ipq8074-wifi"; + reg = <0xc000000 0x2000000>; + interrupts = <0 320 1>, + <0 319 1>, + <0 318 1>, + <0 317 1>, + <0 316 1>, + <0 315 1>, + <0 314 1>, + <0 311 1>, + <0 310 1>, + <0 411 1>, + <0 410 1>, + <0 40 1>, + <0 39 1>, + <0 302 1>, + <0 301 1>, + <0 37 1>, + <0 36 1>, + <0 296 1>, + <0 295 1>, + <0 294 1>, + <0 293 1>, + <0 292 1>, + <0 291 1>, + <0 290 1>, + <0 289 1>, + <0 288 1>, + <0 239 1>, + <0 236 1>, + <0 235 1>, + <0 234 1>, + <0 233 1>, + <0 232 1>, + <0 231 1>, + <0 230 1>, + <0 229 1>, + <0 228 1>, + <0 224 1>, + <0 223 1>, + <0 203 1>, + <0 183 1>, + <0 180 1>, + <0 179 1>, + <0 178 1>, + <0 177 1>, + <0 176 1>, + <0 163 1>, + <0 162 1>, + <0 160 1>, + <0 159 1>, + <0 158 1>, + <0 157 1>, + <0 156 1>; + interrupt-names = "misc-pulse1", + "misc-latch", + "sw-exception", + "watchdog", + "ce0", + "ce1", + "ce2", + "ce3", + "ce4", + "ce5", + "ce6", + "ce7", + "ce8", + "ce9", + "ce10", + "ce11", + "host2wbm-desc-feed", + "host2reo-re-injection", + "host2reo-command", + "host2rxdma-monitor-ring3", + "host2rxdma-monitor-ring2", + "host2rxdma-monitor-ring1", + "reo2ost-exception", + "wbm2host-rx-release", + "reo2host-status", + "reo2host-destination-ring4", + "reo2host-destination-ring3", + "reo2host-destination-ring2", + "reo2host-destination-ring1", + "rxdma2host-monitor-destination-mac3", + "rxdma2host-monitor-destination-mac2", + "rxdma2host-monitor-destination-mac1", + "ppdu-end-interrupts-mac3", + "ppdu-end-interrupts-mac2", + "ppdu-end-interrupts-mac1", + "rxdma2host-monitor-status-ring-mac3", + "rxdma2host-monitor-status-ring-mac2", + "rxdma2host-monitor-status-ring-mac1", + "host2rxdma-host-buf-ring-mac3", + "host2rxdma-host-buf-ring-mac2", + "host2rxdma-host-buf-ring-mac1", + "rxdma2host-destination-ring-mac3", + "rxdma2host-destination-ring-mac2", + "rxdma2host-destination-ring-mac1", + "host2tcl-input-ring4", + "host2tcl-input-ring3", + "host2tcl-input-ring2", + "host2tcl-input-ring1", + "wbm2host-tx-completions-ring3", + "wbm2host-tx-completions-ring2", + "wbm2host-tx-completions-ring1", + "tcl2host-status-ring"; + qcom,rproc = <&qcom_q6v5_wcss>; +};