diff mbox series

ath11k: removing redundant reo unlock followed by immediate lock

Message ID 1591713432-26426-1-git-send-email-ssreeela@codeaurora.org (mailing list archive)
State Accepted
Commit 8cacd0389c4f6056250377f44fbfe18a2501dd79
Delegated to: Kalle Valo
Headers show
Series ath11k: removing redundant reo unlock followed by immediate lock | expand

Commit Message

Sowmiya Sree Elavalagan June 9, 2020, 2:37 p.m. UTC
Removed reo cmd lock and unlock which was acquiring the lock immediately
after unlock. Done for code clean up.

Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Kalle Valo June 15, 2020, 2:29 p.m. UTC | #1
Sowmiya Sree Elavalagan <ssreeela@codeaurora.org> wrote:

> Removed reo cmd lock and unlock which was acquiring the lock immediately
> after unlock. Done for code clean up.
> 
> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

8cacd0389c4f ath11k: removing redundant reo unlock followed by immediate lock
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index a54610d..a010cf7 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -653,10 +653,8 @@  static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx,
 	spin_lock_bh(&dp->reo_cmd_lock);
 	list_add_tail(&elem->list, &dp->reo_cmd_cache_flush_list);
 	dp->reo_cmd_cache_flush_count++;
-	spin_unlock_bh(&dp->reo_cmd_lock);
 
 	/* Flush and invalidate aged REO desc from HW cache */
-	spin_lock_bh(&dp->reo_cmd_lock);
 	list_for_each_entry_safe(elem, tmp, &dp->reo_cmd_cache_flush_list,
 				 list) {
 		if (dp->reo_cmd_cache_flush_count > DP_REO_DESC_FREE_THRESHOLD ||