diff mbox series

[net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service

Message ID 1595237804-66297-1-git-send-email-wangyufen@huawei.com (mailing list archive)
State Accepted
Commit 28f1632118818d9dccabf4c0fccfe49686742317
Delegated to: Kalle Valo
Headers show
Series [net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service | expand

Commit Message

wangyufen July 20, 2020, 9:36 a.m. UTC
When qmi_add_lookup fail, we should destroy the workqueue

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
 drivers/net/wireless/ath/ath11k/qmi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Aug. 18, 2020, 9:51 a.m. UTC | #1
Wang Yufen <wangyufen@huawei.com> wrote:

> When qmi_add_lookup fail, we should destroy the workqueue
> 
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

28f163211881 ath11k: Fix possible memleak in ath11k_qmi_init_service
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index c00a99a..497cff7 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -2419,6 +2419,7 @@  int ath11k_qmi_init_service(struct ath11k_base *ab)
 			     ATH11K_QMI_WLFW_SERVICE_INS_ID_V01);
 	if (ret < 0) {
 		ath11k_warn(ab, "failed to add qmi lookup\n");
+		destroy_workqueue(ab->qmi.event_wq);
 		return ret;
 	}