| Message ID | 1600481191-14250-1-git-send-email-zhangchangzhong@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 72a398a63b88921067ba275e701d19eb442638cd |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] brcmfmac: check return value of driver_for_each_device() | expand |
Zhang Changzhong <zhangchangzhong@huawei.com> wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: > variable 'ret' set but not used [-Wunused-but-set-variable] > 1576 | int ret; > | ^~~ > > driver_for_each_device() has been declared with __must_check, so the > return value should be checked. > > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 72a398a63b88 brcmfmac: check return value of driver_for_each_device()
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index ac54638..6f67fef 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -1578,6 +1578,9 @@ void brcmf_usb_exit(void) brcmf_dbg(USB, "Enter\n"); ret = driver_for_each_device(drv, NULL, NULL, brcmf_usb_reset_device); + if (ret) + brcmf_err("failed to reset all usb devices %d\n", ret); + usb_deregister(&brcmf_usbdrvr); }
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 1576 | int ret; | ^~~ driver_for_each_device() has been declared with __must_check, so the return value should be checked. Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> --- v2: - cc linux-wireless --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 3 +++ 1 file changed, 3 insertions(+)