diff mbox series

ath10k: fix compilation warning

Message ID 1604507837-29361-1-git-send-email-tamizhr@codeaurora.org (mailing list archive)
State Accepted
Commit b9162645117841978a3fb31546409271e007dd28
Delegated to: Kalle Valo
Headers show
Series ath10k: fix compilation warning | expand

Commit Message

Tamizh chelvam Nov. 4, 2020, 4:37 p.m. UTC 
From: Tamizh Chelvam <tamizhr@codeaurora.org>

This change fixes below compilation warning.

smatch warnings:
 drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.

No functional changes. Compile tested only.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kalle Valo Nov. 7, 2020, 7:56 a.m. UTC | #1 
Tamizh chelvam <tamizhr@codeaurora.org> wrote:

> This change fixes below compilation warning.
> 
> smatch warnings:
>  drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.
> 
> No functional changes. Compile tested only.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

b91626451178 ath10k: fix compilation warning
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 12edb1b..9f3224d 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -9182,10 +9182,11 @@  static int ath10k_mac_op_set_tid_config(struct ieee80211_hw *hw,
 			goto exit;
 	}
 
+	ret = 0;
+
 	if (sta)
 		goto exit;
 
-	ret = 0;
 	arvif->tids_rst = 0;
 	data.curr_vif = vif;
 	data.ar = ar;